Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the Lighthouse Chrome extension #8690

Closed
paulirish opened this issue Apr 28, 2019 · 3 comments · Fixed by #9193
Closed

Deprecate the Lighthouse Chrome extension #8690

paulirish opened this issue Apr 28, 2019 · 3 comments · Fixed by #9193

Comments

@paulirish
Copy link
Member

The Chrome extension has a number of challenging issues. It's similar to DevTools as a client, but we can't have nice integration like "view trace" or "click through on node to Elements panel"

Also bugs like #4451 (distorted screenshots)

We've wanted to drop the Chrome extension for a while.

The proposal is that hitting the Browser Action icon would just immediately open DevTools Audits panel.

Implementation-wise: we'll need either protocol-level support to make this happen, an extension API that's exclusive to the LH chrome extension.

@connorjclark
Copy link
Collaborator

connorjclark commented May 14, 2019

Implementation-wise: we'll need either protocol-level support to make this happen, an extension API that's exclusive to the LH chrome extension.

Extension API seemed the most straightforward. I'm not sure how to make an API private to an extension, but maybe activeTab / tab permissions are enough?

Got a work in progress. It needs tests, and perhaps a slight consolidation of older code.

killext

chrome.browserAction.onClicked.addListener(function(tab) {
  chrome.tabs.openDevTools(undefined, 'audits2');
});

I use DevTools's showPanel to open the Audits panel. It's unfortunate that it's named audits2, but we can change that right?

@benjamingr
Copy link

As an extension author I would really prefer fixing the extension API to support three things

@benjamingr
Copy link

:(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants