core(is-on-https): add missing space in description #11466
Conversation
qwright10
requested review from
connorjclark
and removed request for
a team
|
Some testing errors need to be fixed. Marking as draft (for now). |
|
should just need to do |
| @@ -18,7 +18,7 @@ const UIStrings = { | |||
| /** Description of a Lighthouse audit that tells the user *why* HTTPS use *for all resources* is important. This is displayed after a user expands the section to see more. No character length limits. 'Learn More' becomes link text to additional documentation. */ | |||
| description: 'All sites should be protected with HTTPS, even ones that don\'t handle ' + | |||
| 'sensitive data. This includes avoiding [mixed content](https://developers.google.com/web/fundamentals/security/prevent-mixed-content/what-is-mixed-content), ' + | |||
| 'where some resources are loaded over HTTP despite the initial request being served' + | |||
| 'where some resources are loaded over HTTP despite the initial request being served ' + | |||
There was a problem hiding this comment.
ahem this is why I think we should disable max-len lint rule for these few lines and just use one long string.
There was a problem hiding this comment.
was there a discussion about this before?
We could always write a lint rule to find /\S' \+/ and ban it 😆
There was a problem hiding this comment.
our lint settings already allow this string to break max-len because it has a url in it :)
There was a problem hiding this comment.
Yes. No reasonable way to locate it. GitHub comment search is non-existent.
There was a problem hiding this comment.
jk "word wrap" was a pretty good search term. #9105 (comment)
There was a problem hiding this comment.
our lint settings already allow this string to break max-len because it has a url in it :)
there's no emoji reaction awesome enough to react to this so here you go
There was a problem hiding this comment.
jk "word wrap" was a pretty good search term. #9105 (comment)
heh, oh apparently I agreed with you then too.
connorjclark
changed the title
|
Thanks @qwright10! |
|
Marking as "not draft." Seems |
Summary
This PR adds a missing space to the end of a line in the
Uses HTTPSaudit description. Currently, the description appears asservedover, but should beserved overRelated Issues/PRs
None