Add test cases for perf-x database #1597
Conversation
| describe('Perf-X Database', function() { | ||
| it('can store and output experiments data', () => { | ||
| const perfXDatabase = new PerfXDatabase(); | ||
| process.on('exit', () => perfXDatabase.clear()); |
There was a problem hiding this comment.
i'd put this in an afterEach block (some other tests have them)
There was a problem hiding this comment.
and do you want to use a fresh database for each of these test cases? if so you could do setup/teardown in beforeEach/afterEach inside the describe and do each test case in their own it.
There was a problem hiding this comment.
i'd put this in an afterEach block (some other tests have them)
I didn't know that! Thx for your advice
and do you want to use a fresh database for each of these test cases?
Are you referring to testCases or 'it'? I want to test the whether database is capable of storing multiple data sets here. I will rename testCases to dataSets to make it clear.
| }, | ||
| { | ||
| flags: { | ||
| 'blockedUrlPatterns': ['.woff', 'cat.jpg', '*'], |
There was a problem hiding this comment.
pretty odd we have this mix of camel casing and not in the flags. Why arent the disable flags in camelcase?
| const flagsBeforeChange = JSON.parse(JSON.stringify(perfXDatabase.getFlags(key))); | ||
| const resultsBeforeChange = JSON.parse(JSON.stringify(perfXDatabase.getResults(key))); | ||
|
|
||
| // data won't be changed when the falgs/results passed to perfXDatabase.saveData is changed |
|
|
||
| testCases.forEach(testCase => { | ||
| assert.strictEqual(perfXDatabase.timeStamps[testCase.key], testCase.results.generatedTime); | ||
| }); |
There was a problem hiding this comment.
how about an assertion about perfXDatabase.timeStamps.length? (3 is expected)
(I presume this would fail right now, until the process.on exit is changed to an afterEach..)
There was a problem hiding this comment.
how about an assertion about perfXDatabase.timeStamps.length? (3 is expected)
Thx for your advice. I will add that.
also fix some coding style and a typo
Added some test cases for perf-x database
Also refactored the database a little bit and fixed a bug.