Sandboxed module for WebInspector #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 31a2ea2.
This reverts commit 3f7ee0b.
This reverts commit 09f784b.
I think this will work... next steps are to move all the WebInspector calls to inside of the sm.require(). It's failing now because the peekLast is using the outer context when the Array.prototype on the inner context has been updated. I'm curious if there could be a wrapper module.. if so, i feel like all WebInspector calls would have to be WebInspector(). Anyhow. the fix inside this module is moving more over the sm.require() border. seems ok.
… before all this. not sure why so different.
paulirish
added a commit
that referenced
this pull request
Mar 21, 2016
Sandboxed module for WebInspector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boy this was fun stuff.