Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report(bootup-time): fix learn more link #4962

Merged
merged 1 commit into from
Apr 13, 2018
Merged

report(bootup-time): fix learn more link #4962

merged 1 commit into from
Apr 13, 2018

Conversation

underbyte
Copy link
Contributor

No description provided.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

patrickhulce
patrickhulce approved these changes Apr 13, 2018
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome thanks for the fix @underbyte! 👍 💯

@patrickhulce patrickhulce changed the title core(performance): fix link for bootup time report(bootup-time): fix learn more link Apr 13, 2018
patrickhulce
patrickhulce reviewed Apr 13, 2018
View reviewed changes
lighthouse-core/test/results/sample_v2.json
@@ -1101,7 +1101,7 @@
"scoreDisplayMode": "numeric",
"name": "bootup-time",
"description": "JavaScript boot-up time",
"helpText": "Consider reducing the time spent parsing, compiling, and executing JS. You may find delivering smaller JS payloads helps with this. [Learn more](https://developers.google.com/web/lighthouse/audits/bootup).",
"helpText": "Consider reducing the time spent parsing, compiling, and executing JS. You may find delivering smaller JS payloads helps with this. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/bootup).",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulirish yeah ignore help text is a good call for our golden file assertions :)

@patrickhulce
Copy link
Collaborator

@underbyte mind your 🖊 on the CLA to make the 🕴 happy? :)

@4194sunny
Copy link

Like

@paulirish paulirish mentioned this pull request Apr 13, 2018
Merged
@underbyte
Copy link
Contributor Author

@patrickhulce The CLA site says I have one. Do I need to configure it in github or anything?

@patrickhulce
Copy link
Collaborator

oh probably just email issue then with git config thanks! 👍

@patrickhulce patrickhulce merged commit 9ea3c17 into GoogleChrome:master Apr 13, 2018
@underbyte underbyte deleted the contribution-edit branch April 14, 2018 02:19
@kdzwinel kdzwinel mentioned this pull request Apr 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

@brendankenny brendankenny Awaiting requested review from brendankenny

@paulirish paulirish Awaiting requested review from paulirish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@underbyte @googlebot @patrickhulce @4194sunny