Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox old versions - throw an empty/unknown list of entryTypes #7

Closed
Zizzamia opened this issue Apr 21, 2020 · 3 comments
Closed

Comments

@Zizzamia
Copy link
Contributor

Zizzamia commented Apr 21, 2020

There is this old issue related to using PerformanceObserver with entryTypes 'paint' in Firefox v58: https://bugzilla.mozilla.org/show_bug.cgi?id=1403027 .

It is not a problem anymore, I think was fixed with v63. In case the library is looking to support older versions of Firefox, I found it could be convenient to wrap the PerformanceObserver in a try/catch for getFCP.

I can open a PR for it, but I thought to double-check first if you were interested in such a fix.

@philipwalton
Copy link
Member

Thanks. I wasn't aware of that bug, though from looking at the code, I already do put that check in a try/catch block, so I think it should be ok, no?

@Zizzamia
Copy link
Contributor Author

Oh, I miss that. Yeah, we should be good! I'm going to close this issue.
More an open question, should the library expose any error caught, maybe with an onError listener that devs can use to connect Bugsnag or their favorite bug report tool?

@philipwalton
Copy link
Member

More an open question, should the library expose any error caught, maybe with an onError listener that devs can use to connect Bugsnag or their favorite bug report tool?

Hmmm, I don't think we'd want to report errors for expected failures (e.g. a browser just not supporting the API), and other than that I'd assume developers wanting to catch errors would just use try/catch or standard uncaught error handling mechanisms?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants