You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It is not a problem anymore, I think was fixed with v63. In case the library is looking to support older versions of Firefox, I found it could be convenient to wrap the PerformanceObserver in a try/catch for getFCP.
I can open a PR for it, but I thought to double-check first if you were interested in such a fix.
The text was updated successfully, but these errors were encountered:
Oh, I miss that. Yeah, we should be good! I'm going to close this issue.
More an open question, should the library expose any error caught, maybe with an onError listener that devs can use to connect Bugsnag or their favorite bug report tool?
More an open question, should the library expose any error caught, maybe with an onError listener that devs can use to connect Bugsnag or their favorite bug report tool?
Hmmm, I don't think we'd want to report errors for expected failures (e.g. a browser just not supporting the API), and other than that I'd assume developers wanting to catch errors would just use try/catch or standard uncaught error handling mechanisms?
There is this old issue related to using
PerformanceObserver
withentryTypes
'paint' in Firefox v58: https://bugzilla.mozilla.org/show_bug.cgi?id=1403027 .It is not a problem anymore, I think was fixed with v63. In case the library is looking to support older versions of Firefox, I found it could be convenient to wrap the
PerformanceObserver
in atry/catch
forgetFCP
.I can open a PR for it, but I thought to double-check first if you were interested in such a fix.
The text was updated successfully, but these errors were encountered: