Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Disable lint definition-case #4115

Merged

Conversation

beaufortfrancois
Copy link
Member

This PR is about removing the lint rule "definition-case" as suggested by @kaycebasques at https://github.com/GoogleChrome/web.dev/pull/4107/files#r509726431

@github-actions
Copy link

Alex Recommends Report

Alex recommends the following language changes, but Alex is a regular expression based algorithm, so take them with a grain of salt.

src/site/content/en/blog/app-shortcuts/index.md

Level Location Word Recommendation
⚠️ 35:10 Easy Easy may be insensitive, try not to use it
⚠️ 70:41 special special may be insensitive, use has a disability, person with a disability, people with disabilities instead
⚠️ 159:50 easy easy may be insensitive, try not to use it
⚠️ 205:31 easily easily may be insensitive, try not to use it

src/site/content/en/blog/bluetooth/index.md

Level Location Word Recommendation
⚠️ 87:16 simply simply may be insensitive, try not to use it
⚠️ 97:43 simply simply may be insensitive, try not to use it
⚠️ 251:50 easy easy may be insensitive, try not to use it
⚠️ 429:41 simple simple may be insensitive, try not to use it
⚠️ 480:1 Hero Hero may be insensitive, use Role-model, Mentor instead

src/site/content/en/blog/camera-pan-tilt-zoom/index.md

Level Location Word Recommendation
⚠️ 217:1 Hero Hero may be insensitive, use Role-model, Mentor instead

src/site/content/en/blog/hid/index.md

Level Location Word Recommendation
⚠️ 76:40 host host may be insensitive, use presenter, entertainer, emcee instead
⚠️ 131:8 just just may be insensitive, try not to use it
⚠️ 370:28 easy easy may be insensitive, try not to use it
⚠️ 421:28 simple simple may be insensitive, try not to use it
⚠️ 423:19 easy easy may be insensitive, try not to use it

src/site/content/en/blog/media-session/index.md

Level Location Word Recommendation
⚠️ 66:62 easily easily may be insensitive, try not to use it
⚠️ 187:48 easy easy may be insensitive, try not to use it
⚠️ 323:75 simple simple may be insensitive, try not to use it
⚠️ 373:36 easy easy may be insensitive, try not to use it

src/site/content/en/blog/nfc/index.md

Level Location Word Recommendation
⚠️ 25:70 just just may be insensitive, try not to use it
⚠️ 49:28 easily easily may be insensitive, try not to use it
⚠️ 442:42 primitive primitive may be insensitive, use simple, indigenous, hunter-gatherer instead
⚠️ 442:61 easy easy may be insensitive, try not to use it
⚠️ 478:12 simple simple may be insensitive, try not to use it
⚠️ 592:54 simple simple may be insensitive, try not to use it
⚠️ 802:27 easily easily may be insensitive, try not to use it
⚠️ 804:46 easy easy may be insensitive, try not to use it
⚠️ 853:28 simple simple may be insensitive, try not to use it
⚠️ 855:19 easy easy may be insensitive, try not to use it
⚠️ 880:22 special special may be insensitive, use has a disability, person with a disability, people with disabilities instead

src/site/content/en/blog/serial/index.md

Level Location Word Recommendation
⚠️ 26:73 just just may be insensitive, try not to use it
⚠️ 101:5 just just may be insensitive, try not to use it
⚠️ 511:39 easy easy may be insensitive, try not to use it
⚠️ 566:28 simple simple may be insensitive, try not to use it
⚠️ 568:19 easy easy may be insensitive, try not to use it

src/site/content/en/blog/usb/index.md

Level Location Word Recommendation
⚠️ 22:23 simply simply may be insensitive, try not to use it
⚠️ 115:5 simply simply may be insensitive, try not to use it
⚠️ 147:11 simply simply may be insensitive, try not to use it
⚠️ 152:37 Basically Basically may be insensitive, try not to use it
⚠️ 164:21 simply simply may be insensitive, try not to use it
⚠️ 178:25 easy easy may be insensitive, try not to use it
⚠️ 209:63 just just may be insensitive, try not to use it
⚠️ 240:1 basically basically may be insensitive, try not to use it
⚠️ 257:30 host host may be insensitive, use presenter, entertainer, emcee instead
⚠️ 315:53 just just may be insensitive, try not to use it

@netlify
Copy link

netlify bot commented Oct 23, 2020

Deploy preview for web-dev-staging ready!

Built with commit 4e87c4c

https://deploy-preview-4115--web-dev-staging.netlify.app

Copy link
Contributor

@kaycebasques kaycebasques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you for the drive-by codebase cleanups @beaufortfrancois

Still requires a review from @GoogleChrome/web-dev-eng

@beaufortfrancois
Copy link
Member Author

@samthor @robdodson @devnook Can you review?

@robdodson robdodson merged commit 1dc38a6 into GoogleChrome:master Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Contributor has signed the CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants