Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Improve cross-origin isolation related documents #4693

Merged
merged 3 commits into from
Feb 19, 2021
Merged

Conversation

agektmr
Copy link
Member

@agektmr agektmr commented Feb 18, 2021

Improves cross-origin isolation related documents

Here's list of changes:

  • Add report only mode step in the guide to recursively apply COEP to iframes.
  • Add explanation about allow="cross-origin-isolated" to enable SharedArrayBuffer etc within an iframe.
  • Add instructions how to check iframe and popup window's status of cross-origin isolation on DevTools.

@chrome-devrel-review-bot
Copy link
Collaborator

chrome-devrel-review-bot commented Feb 18, 2021

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Staging URLs

For your convenience, here are direct links (on our staging site) to the content you created or updated:

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

src/site/content/en/blog/coop-coep/index.md

  • Please break lines at 100 characters maximum. Long lines can be difficult to work with in GitHub's pull request UI. The following tools can help speed up the process: Rewrap (VS Code), Docs To X (Google Docs; only available for Googlers). Affected lines: 129, 230, 236, 246, 252, 333, 347, 418, 441, 463, 475
  • Please change your usage of the following words:

src/site/content/en/secure/cross-origin-isolation-guide/index.md

  • This file passed all of our automated Markdown audits.

@google-cla google-cla bot added the cla: yes Contributor has signed the CLA label Feb 18, 2021
@github-actions
Copy link

Alex Recommends Report

Alex recommends the following language changes, but Alex is a regular expression based algorithm, so take them with a grain of salt.

src/site/content/en/blog/coop-coep/index.md

Level Location Word Recommendation
⚠️ 52:62 disabled disabled may be insensitive, use turned off, has a disability, person with a disability, people with disabilities instead
⚠️ 214:75 easy easy may be insensitive, try not to use it
⚠️ 459:74 special special may be insensitive, use has a disability, person with a disability, people with disabilities instead

src/site/content/en/secure/cross-origin-isolation-guide/index.md

Level Location Word Recommendation
⚠️ 29:73 just just may be insensitive, try not to use it

@netlify
Copy link

netlify bot commented Feb 18, 2021

Deploy preview for web-dev-staging ready!

Built with commit 394e269

https://deploy-preview-4693--web-dev-staging.netlify.app

@agektmr
Copy link
Member Author

agektmr commented Feb 18, 2021

@lutzvahl can you review these changes?

@mihajlija mihajlija self-assigned this Feb 18, 2021
@kaycebasques
Copy link
Contributor

@agektmr merge yourself when ready please

@lutzvahl
Copy link

LGTM content wise

@agektmr agektmr merged commit 350ab34 into main Feb 19, 2021
@agektmr agektmr deleted the coop-coep-update branch February 19, 2021 08:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Contributor has signed the CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants