This repository has been archived by the owner on Mar 14, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Improve cross-origin isolation related documents #4693
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated. Staging URLsFor your convenience, here are direct links (on our staging site) to the content you created or updated:
Requested changesIf there are any common problems with the content files you created or modified, they will be listed here.
|
Alex Recommends ReportAlex recommends the following language changes, but Alex is a regular expression based algorithm, so take them with a grain of salt. src/site/content/en/blog/coop-coep/index.md
src/site/content/en/secure/cross-origin-isolation-guide/index.md
|
Deploy preview for web-dev-staging ready! Built with commit 394e269 |
@lutzvahl can you review these changes? |
mihajlija
reviewed
Feb 18, 2021
src/site/content/en/secure/cross-origin-isolation-guide/index.md
Outdated
Show resolved
Hide resolved
mihajlija
approved these changes
Feb 18, 2021
@agektmr merge yourself when ready please |
LGTM content wise |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves cross-origin isolation related documents
Here's list of changes:
allow="cross-origin-isolated"
to enable SharedArrayBuffer etc within an iframe.