Undocumented v6 breaking change: PrecacheController.install/active

[slorber]

Hi,

Not 100% sure but it seems like in the code and TS typedefs, the PrecacheController install/activate methods now take the event as param, while it wasn't the case before.

Not passing the event lead to console errors after an upgrade:

Uncaught TypeError: Cannot read property 'waitUntil' of undefined

FYI the doc seems wrong to me and this is also not mentioned on the v5-v6 breaking changes, and might be useful to add/fix ;)

https://developers.google.com/web/tools/workbox/modules/workbox-precaching

[jeffposnick]

Thank you for pointing this out—yes, PrecacheController does require an ExtendableEvent to be passed in as a parameter to both its install() and activate() methods in v6.

I'll get the JSDoc and other guidance updated to make it clear that this changed, and is a breaking change.

[slorber]

thanks :)