Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include removed TS definitions in Workbox code #2946

Closed
jeffposnick opened this issue Sep 23, 2021 · 0 comments · Fixed by #2950
Closed

Include removed TS definitions in Workbox code #2946

jeffposnick opened this issue Sep 23, 2021 · 0 comments · Fixed by #2950
Labels
TypeScript Issues related to our TypeScript annotations. workbox-background-sync workbox-navigation-preload workbox-strategies

Comments

@jeffposnick
Copy link
Contributor

TypeScript 4.4.0 removed a few definitions from libdom that correspond to features that are only currently implemented in Chrome: microsoft/TypeScript-DOM-lib-generator#1029

ServiceWorkerRegistration

  • navigationPreload
  • sync

FetchEvent

  • preloadResponse (It's not mentioned in the release notes, but appears to be gone.)

Global

  • SyncEvent (It's not mentioned in the release notes, but appears to be gone.)

We should ship definitions for those based on the previous libdom entries inside the Workbox modules that refer to them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
TypeScript Issues related to our TypeScript annotations. workbox-background-sync workbox-navigation-preload workbox-strategies
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updates for TypeScript 4.4.3 GoogleChrome/workbox
1 participant
@jeffposnick