Only search dom for closest A once

GoogleChromeLabs · Oct 11, 2018 · 35b9f0b · 35b9f0b
1 parent fd18755
commit 35b9f0b
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/theme/scripts/router.js b/src/theme/scripts/router.js
@@ -34,9 +34,10 @@ class Router {
   }
 
   async _onLinkClick(event) {
-    // See if what is clicked has an anchor as parent or is a link itself and create an URL of it
-    const link = event.target.closest('a') ? new URL(event.target.closest('a').href) : null;
-    if (!link) return;
+    // See if what is clicked has an anchor as parent or is a link itself. If so create URL otherwise return.
+    const linkElement = event.target.closest('a');
+    if (!linkElement) return;
+    const link = new URL(linkElement.href);
 
     // If it’s an external link, just navigate.
     if(link.host !== this._hostname) {