fix: handle pseudo-class in middle of selector #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
At the moment critters doesn't correctly handle pseudo-class in the middle of the selector string and pseudo-class which take a value such as `:not` Example ``` .mat-slider:hover .mat-slider-track-background .mat-slider-min-value:not(.mat-slider-thumb-label-showing):hover.mat-slider-disabled .mat-slider-thumb ``` More context about CSS pseudo-classes can be found https://developer.mozilla.org/en-US/docs/Web/CSS/Pseudo-classes Closes GoogleChromeLabs#51
alan-agius4
force-pushed
the
preudo-class
branch
from
6d5c5d8
to
550eebf
Compare
|
@janicklas-ralph mind taking a look at this? |
developit
approved these changes
Jan 8, 2021
developit
reviewed
Jan 8, 2021
alan-agius4
force-pushed
the
preudo-class
branch
2 times, most recently
from
df47245
to
d0acb0b
Compare
Class names can have `:` if they are escapped. Example: `.flex\:box`
alan-agius4
force-pushed
the
preudo-class
branch
from
d0acb0b
to
cf38bdf
Compare
|
@developit, changes done. PTAL. |
developit
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: handle pseudo-class in middle of selector
At the moment critters doesn't correctly handle pseudo-class in the middle of the selector string and pseudo-class which take a value such as
:notExample
More context about CSS pseudo-classes can be found https://developer.mozilla.org/en-US/docs/Web/CSS/Pseudo-classes
Closes #51
fix: handle classes with colons
Class names can have
:if they are escapped. Example:.flex\:box