Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular.json - optimization configuration styles: inlineCritical generates warning on compilation #20031

Closed
ciprian1992 opened this issue Feb 11, 2021 · 3 comments · Fixed by #20039

Comments

@ciprian1992
Copy link

🐞 bug report

Affected Package

The issue is caused by package @angular/compiler 11 i guess

Is this a regression?

No.

Description

Angular.json optmization configuration:


"optimization": {
    "styles": {
        "inlineCritical": true
    }
},

🔬 Minimal Reproduction

https://stackblitz.com/...

🔥 Exception or Error


740 rules skipped due to selector errors:
  .b-gridbase.b-sort:not(.b-column-resizing) .b-grid-header-container:not(.b-dragging-header) .b-grid-header.b-sortable.b-depth-0:focus:not(.b-sort):not(.b-group) .b-grid-header-text -> unmatched pseudo-class :focus
....


🌍 Your Environment

Angular Version:




     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/
    

Angular CLI: 11.1.4
Node: 10.16.0
OS: win32 x64

Angular: 11.2.0
... animations, cdk, common, compiler, compiler-cli, core
... elements, forms, language-service, material
... material-moment-adapter, platform-browser
... platform-browser-dynamic, router
Ivy Workspace: Yes

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1101.4
@angular-devkit/build-angular   0.1101.4
@angular-devkit/core            11.1.4
@angular-devkit/schematics      11.1.4
@angular/cli                    11.1.4
@schematics/angular             11.1.4
@schematics/update              0.1101.4
rxjs                            6.6.3
typescript                      4.0.5

Anything else relevant?

@petebacondarwin
Copy link
Member

Transferring to CLI project...

@petebacondarwin petebacondarwin transferred this issue from angular/angular Feb 11, 2021
@alan-agius4
Copy link
Collaborator

This should be solve by GoogleChromeLabs/critters#68. However, we are currently blocked on a an upstream release.

// cc @mgechev & @developit.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants