fix: scss code using keyframes should successfully transform #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I submitted a CLA a long time ago for the email address associated with this GH account. Just tried to re-sign it but it said that there was already an outstanding request. |
developit
approved these changes
Jan 5, 2022
|
I think the CLA bot is checking only for your |
|
Kk I’ll look in a few. I saw you merged tho. Do I need to sign still?
…On Wed, Jan 5, 2022 at 10:33 AM Jason Miller ***@***.***> wrote:
I think the CLA bot is checking only for your jessicasachs@ address, not
***@***.***
—
Reply to this email directly, view it on GitHub
<#96 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVL4BEGOE3NPGARYSLUGHLUURQF5ANCNFSM5K62DLPA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This was referenced Jan 5, 2022
1 task
1 task
kodiakhq bot
pushed a commit
to X-oss-byte/Canary-nextjs
that referenced
this pull request
Sep 22, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [critters](https://togithub.com/GoogleChromeLabs/critters) | [`0.0.6` -> `0.0.20`](https://renovatebot.com/diffs/npm/critters/0.0.6/0.0.20) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>GoogleChromeLabs/critters (critters)</summary> ### [`v0.0.20`](https://togithub.com/GoogleChromeLabs/critters/compare/3b3ea7b1ad8ca4d5e40cdf793aecc1b4dcaa5e1c...0.0.20) [Compare Source](https://togithub.com/GoogleChromeLabs/critters/compare/3b3ea7b1ad8ca4d5e40cdf793aecc1b4dcaa5e1c...0.0.20) ### [`v0.0.19`](https://togithub.com/GoogleChromeLabs/critters/compare/bcce3103f9e754cd8c3d8b1681f7e1cf6e536282...3b3ea7b1ad8ca4d5e40cdf793aecc1b4dcaa5e1c) [Compare Source](https://togithub.com/GoogleChromeLabs/critters/compare/bcce3103f9e754cd8c3d8b1681f7e1cf6e536282...3b3ea7b1ad8ca4d5e40cdf793aecc1b4dcaa5e1c) ### [`v0.0.18`](https://togithub.com/GoogleChromeLabs/critters/compare/1f8a941a069cfeb68450d33a42187c5398496fd7...bcce3103f9e754cd8c3d8b1681f7e1cf6e536282) [Compare Source](https://togithub.com/GoogleChromeLabs/critters/compare/1f8a941a069cfeb68450d33a42187c5398496fd7...bcce3103f9e754cd8c3d8b1681f7e1cf6e536282) ### [`v0.0.17`](https://togithub.com/GoogleChromeLabs/critters/blob/HEAD/CHANGELOG.md#v0017) [Compare Source](https://togithub.com/GoogleChromeLabs/critters/compare/critters-0.0.16...1f8a941a069cfeb68450d33a42187c5398496fd7) - Updated the HTML parser from parse5 to htmlparser2 - Implemented caching to improve speed of matching class and id based selectors - Added option `includeSelectors` - Added option `reduceInlineStyles` Feature Include/Exclude CSS rules via comments in CSS Feature Adding Critters containers. Wrap the HTML contents in a `data-critters-container` container to indicate above the fold HTML. ### [`v0.0.16`](https://togithub.com/GoogleChromeLabs/critters/releases/tag/critters-0.0.16) [Compare Source](https://togithub.com/GoogleChromeLabs/critters/compare/critters-0.0.15...critters-0.0.16) #### What's Changed - Add support for `:where` selector by [@​jeripeierSBB](https://togithub.com/jeripeierSBB) in [GoogleChromeLabs/critters#93 - Fix inlining of `-webkit-keyframes` (often generated by scss) by [@​JessicaSachs](https://togithub.com/JessicaSachs) in [GoogleChromeLabs/critters#96 (see [#​86](https://togithub.com/GoogleChromeLabs/critters/issues/86)) - Fix fs import breaking in ESM builds by [@​developit](https://togithub.com/developit) in [GoogleChromeLabs/critters#97 - Document `preload:false` option by [@​kurtextrem](https://togithub.com/kurtextrem) in [GoogleChromeLabs/critters#95 #### New Contributors - [@​JessicaSachs](https://togithub.com/JessicaSachs) made their first contribution in [GoogleChromeLabs/critters#96 - [@​kurtextrem](https://togithub.com/kurtextrem) made their first contribution in [GoogleChromeLabs/critters#95 - [@​jeripeierSBB](https://togithub.com/jeripeierSBB) made their first contribution in [GoogleChromeLabs/critters#93 **Full Changelog**: GoogleChromeLabs/critters@critters-0.0.15...critters-0.0.16 ### [`v0.0.15`](https://togithub.com/GoogleChromeLabs/critters/releases/tag/critters-0.0.15): critters 0.0.15 [Compare Source](https://togithub.com/GoogleChromeLabs/critters/compare/critters-0.0.14...critters-0.0.15) - Bugfix: add missing getter for `document.head` ([#​87](https://togithub.com/GoogleChromeLabs/critters/issues/87), thanks [@​rschristian](https://togithub.com/rschristian)!) ### [`v0.0.14`](https://togithub.com/GoogleChromeLabs/critters/compare/critters-0.0.13...critters-0.0.14) [Compare Source](https://togithub.com/GoogleChromeLabs/critters/compare/critters-0.0.13...critters-0.0.14) ### [`v0.0.13`](https://togithub.com/GoogleChromeLabs/critters/releases/tag/critters-0.0.13) [Compare Source](https://togithub.com/GoogleChromeLabs/critters/compare/critters-0.0.12...critters-0.0.13) This fixes a bug in `critters@0.0.12` where HTTP (as opposed to HTTPS) remote stylesheets were not skipped (thanks [@​alan-agius4](https://togithub.com/alan-agius4) - [#​83](https://togithub.com/GoogleChromeLabs/critters/issues/83)) **Full Changelog**: GoogleChromeLabs/critters@critters-0.0.12...critters-0.0.13 ### [`v0.0.12`](https://togithub.com/GoogleChromeLabs/critters/releases/tag/critters-0.0.12): Critters 0.0.12 #### What's Changed - Update parser to postcss by [@​janicklas-ralph](https://togithub.com/janicklas-ralph) in [GoogleChromeLabs/critters#80 - fix: update css-select to version 4 by [@​alan-agius4](https://togithub.com/alan-agius4) in [GoogleChromeLabs/critters#82 - fix: skip processing of remote stylesheets by [@​alan-agius4](https://togithub.com/alan-agius4) in [GoogleChromeLabs/critters#75 - Improve TypeScript typings by [@​developit](https://togithub.com/developit) in [GoogleChromeLabs/critters#76 - Add swap-high preload mode by [@​developit](https://togithub.com/developit) in [GoogleChromeLabs/critters#56 **Full Changelog**: GoogleChromeLabs/critters@57c4b40...critters-0.0.12 ### [`v0.0.10`](https://togithub.com/GoogleChromeLabs/critters/compare/e9a687265cd003fcbf27e7802d7b8c72168c8a14...1f23cb5b488effe0f782cc6855013fdaec38924c) [Compare Source](https://togithub.com/GoogleChromeLabs/critters/compare/e9a687265cd003fcbf27e7802d7b8c72168c8a14...1f23cb5b488effe0f782cc6855013fdaec38924c) ### [`v0.0.9`](https://togithub.com/GoogleChromeLabs/critters/compare/0524b2e297eb995238b29cad01fadd49524d98bd...e9a687265cd003fcbf27e7802d7b8c72168c8a14) [Compare Source](https://togithub.com/GoogleChromeLabs/critters/compare/0524b2e297eb995238b29cad01fadd49524d98bd...e9a687265cd003fcbf27e7802d7b8c72168c8a14) ### [`v0.0.8`](https://togithub.com/GoogleChromeLabs/critters/compare/0524b2e297eb995238b29cad01fadd49524d98bd...0524b2e297eb995238b29cad01fadd49524d98bd) [Compare Source](https://togithub.com/GoogleChromeLabs/critters/compare/0524b2e297eb995238b29cad01fadd49524d98bd...0524b2e297eb995238b29cad01fadd49524d98bd) ### [`v0.0.7`](https://togithub.com/GoogleChromeLabs/critters/compare/99d5070b58e5edc861f5ac6cdc8fc15223a04bfc...0524b2e297eb995238b29cad01fadd49524d98bd) [Compare Source](https://togithub.com/GoogleChromeLabs/critters/compare/99d5070b58e5edc861f5ac6cdc8fc15223a04bfc...0524b2e297eb995238b29cad01fadd49524d98bd) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/sammyfilly/Canary-nextjs).
](https://renovatebot.com){kind=link}
kodiakhq bot
pushed a commit
to X-oss-byte/Nextjs
that referenced
this pull request
Sep 25, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [critters](https://togithub.com/GoogleChromeLabs/critters) | [`0.0.6` -> `0.0.20`](https://renovatebot.com/diffs/npm/critters/0.0.6/0.0.20) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>GoogleChromeLabs/critters (critters)</summary> ### [`v0.0.20`](https://togithub.com/GoogleChromeLabs/critters/compare/3b3ea7b1ad8ca4d5e40cdf793aecc1b4dcaa5e1c...0.0.20) [Compare Source](https://togithub.com/GoogleChromeLabs/critters/compare/3b3ea7b1ad8ca4d5e40cdf793aecc1b4dcaa5e1c...0.0.20) ### [`v0.0.19`](https://togithub.com/GoogleChromeLabs/critters/compare/bcce3103f9e754cd8c3d8b1681f7e1cf6e536282...3b3ea7b1ad8ca4d5e40cdf793aecc1b4dcaa5e1c) [Compare Source](https://togithub.com/GoogleChromeLabs/critters/compare/bcce3103f9e754cd8c3d8b1681f7e1cf6e536282...3b3ea7b1ad8ca4d5e40cdf793aecc1b4dcaa5e1c) ### [`v0.0.18`](https://togithub.com/GoogleChromeLabs/critters/compare/1f8a941a069cfeb68450d33a42187c5398496fd7...bcce3103f9e754cd8c3d8b1681f7e1cf6e536282) [Compare Source](https://togithub.com/GoogleChromeLabs/critters/compare/1f8a941a069cfeb68450d33a42187c5398496fd7...bcce3103f9e754cd8c3d8b1681f7e1cf6e536282) ### [`v0.0.17`](https://togithub.com/GoogleChromeLabs/critters/blob/HEAD/CHANGELOG.md#v0017) [Compare Source](https://togithub.com/GoogleChromeLabs/critters/compare/critters-0.0.16...1f8a941a069cfeb68450d33a42187c5398496fd7) - Updated the HTML parser from parse5 to htmlparser2 - Implemented caching to improve speed of matching class and id based selectors - Added option `includeSelectors` - Added option `reduceInlineStyles` Feature Include/Exclude CSS rules via comments in CSS Feature Adding Critters containers. Wrap the HTML contents in a `data-critters-container` container to indicate above the fold HTML. ### [`v0.0.16`](https://togithub.com/GoogleChromeLabs/critters/releases/tag/critters-0.0.16) [Compare Source](https://togithub.com/GoogleChromeLabs/critters/compare/critters-0.0.15...critters-0.0.16) #### What's Changed - Add support for `:where` selector by [@​jeripeierSBB](https://togithub.com/jeripeierSBB) in [GoogleChromeLabs/critters#93 - Fix inlining of `-webkit-keyframes` (often generated by scss) by [@​JessicaSachs](https://togithub.com/JessicaSachs) in [GoogleChromeLabs/critters#96 (see [#​86](https://togithub.com/GoogleChromeLabs/critters/issues/86)) - Fix fs import breaking in ESM builds by [@​developit](https://togithub.com/developit) in [GoogleChromeLabs/critters#97 - Document `preload:false` option by [@​kurtextrem](https://togithub.com/kurtextrem) in [GoogleChromeLabs/critters#95 #### New Contributors - [@​JessicaSachs](https://togithub.com/JessicaSachs) made their first contribution in [GoogleChromeLabs/critters#96 - [@​kurtextrem](https://togithub.com/kurtextrem) made their first contribution in [GoogleChromeLabs/critters#95 - [@​jeripeierSBB](https://togithub.com/jeripeierSBB) made their first contribution in [GoogleChromeLabs/critters#93 **Full Changelog**: GoogleChromeLabs/critters@critters-0.0.15...critters-0.0.16 ### [`v0.0.15`](https://togithub.com/GoogleChromeLabs/critters/releases/tag/critters-0.0.15): critters 0.0.15 [Compare Source](https://togithub.com/GoogleChromeLabs/critters/compare/critters-0.0.14...critters-0.0.15) - Bugfix: add missing getter for `document.head` ([#​87](https://togithub.com/GoogleChromeLabs/critters/issues/87), thanks [@​rschristian](https://togithub.com/rschristian)!) ### [`v0.0.14`](https://togithub.com/GoogleChromeLabs/critters/compare/critters-0.0.13...critters-0.0.14) [Compare Source](https://togithub.com/GoogleChromeLabs/critters/compare/critters-0.0.13...critters-0.0.14) ### [`v0.0.13`](https://togithub.com/GoogleChromeLabs/critters/releases/tag/critters-0.0.13) [Compare Source](https://togithub.com/GoogleChromeLabs/critters/compare/critters-0.0.12...critters-0.0.13) This fixes a bug in `critters@0.0.12` where HTTP (as opposed to HTTPS) remote stylesheets were not skipped (thanks [@​alan-agius4](https://togithub.com/alan-agius4) - [#​83](https://togithub.com/GoogleChromeLabs/critters/issues/83)) **Full Changelog**: GoogleChromeLabs/critters@critters-0.0.12...critters-0.0.13 ### [`v0.0.12`](https://togithub.com/GoogleChromeLabs/critters/releases/tag/critters-0.0.12): Critters 0.0.12 #### What's Changed - Update parser to postcss by [@​janicklas-ralph](https://togithub.com/janicklas-ralph) in [GoogleChromeLabs/critters#80 - fix: update css-select to version 4 by [@​alan-agius4](https://togithub.com/alan-agius4) in [GoogleChromeLabs/critters#82 - fix: skip processing of remote stylesheets by [@​alan-agius4](https://togithub.com/alan-agius4) in [GoogleChromeLabs/critters#75 - Improve TypeScript typings by [@​developit](https://togithub.com/developit) in [GoogleChromeLabs/critters#76 - Add swap-high preload mode by [@​developit](https://togithub.com/developit) in [GoogleChromeLabs/critters#56 **Full Changelog**: GoogleChromeLabs/critters@57c4b40...critters-0.0.12 ### [`v0.0.10`](https://togithub.com/GoogleChromeLabs/critters/compare/e9a687265cd003fcbf27e7802d7b8c72168c8a14...1f23cb5b488effe0f782cc6855013fdaec38924c) [Compare Source](https://togithub.com/GoogleChromeLabs/critters/compare/e9a687265cd003fcbf27e7802d7b8c72168c8a14...1f23cb5b488effe0f782cc6855013fdaec38924c) ### [`v0.0.9`](https://togithub.com/GoogleChromeLabs/critters/compare/0524b2e297eb995238b29cad01fadd49524d98bd...e9a687265cd003fcbf27e7802d7b8c72168c8a14) [Compare Source](https://togithub.com/GoogleChromeLabs/critters/compare/0524b2e297eb995238b29cad01fadd49524d98bd...e9a687265cd003fcbf27e7802d7b8c72168c8a14) ### [`v0.0.8`](https://togithub.com/GoogleChromeLabs/critters/compare/0524b2e297eb995238b29cad01fadd49524d98bd...0524b2e297eb995238b29cad01fadd49524d98bd) [Compare Source](https://togithub.com/GoogleChromeLabs/critters/compare/0524b2e297eb995238b29cad01fadd49524d98bd...0524b2e297eb995238b29cad01fadd49524d98bd) ### [`v0.0.7`](https://togithub.com/GoogleChromeLabs/critters/compare/99d5070b58e5edc861f5ac6cdc8fc15223a04bfc...0524b2e297eb995238b29cad01fadd49524d98bd) [Compare Source](https://togithub.com/GoogleChromeLabs/critters/compare/99d5070b58e5edc861f5ac6cdc8fc15223a04bfc...0524b2e297eb995238b29cad01fadd49524d98bd) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/X-oss-byte/Nextjs).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies the suggested fix in #86. Should fix a lot of packages that are dependent on tailwind or windicss animations (like the Vitesse starter template https://github.com/antfu/vitesse, antfu-collective/vite-ssg#158).