-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move common logic to size-plugin-core #27
base: master
Are you sure you want to change the base?
Conversation
* mjs to js * updated package.json * fixed typo (,) * added publish-size * publish size for master branch * fixed typo * fixed payload for size api * size-store api configurable via env variable * avoid publishing in test environment * added todo * pushed filename to store * checked file before writing/reading * corrected file write condition * updated test * moved fs-extra to dependencies * added filename to diff payload * add publish flag * add writeFile option * js to mjs
Co-Authored-By: Jason Miller <developit@users.noreply.github.com>
Thank you for adding compression(gzip/brotli) option!!! 🎉 🎉 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me to be release! Thank you
Just a friendly ping, what's happening here? |
@jimblue This one is taking a while because @kuldeepkeshwar and I have been discussing structural options. I think we landed on a monorepo setup, but I haven't had a chance to branch from this PR and Kuldeep's logic in. |
@developit I can open a pull request here with a monorepo setup 🙃. Packages:
|
are we going ahead for monorepo architecture? I want brotli support in this plugin but looks like it's blocked because of that decision |
Change: