Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reset to the ConnectorRegistry #301

Closed
ttosta-google opened this issue Nov 14, 2023 · 0 comments · Fixed by #304
Closed

Add reset to the ConnectorRegistry #301

ttosta-google opened this issue Nov 14, 2023 · 0 comments · Fixed by #304
Assignees
@ttosta-google
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@ttosta-google
Copy link
Contributor

ttosta-google commented Nov 14, 2023 •
edited
Loading

Feature Description

An application should use the public Java API to reset the connector registry.

  • ConnectorRegistry.reset() - Stops all threads, clears all config, future attempts to connect will start a new Connector.

An application would use reset() when it needs to reload its configuration. This would gracefully close all Connector instances, causing them to reload on the next connection attempt.

This is porting GoogleCloudPlatform/cloud-sql-jdbc-socket-factory#1688 to alloydb-java-connector.
@ttosta-google ttosta-google added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Nov 14, 2023
@ttosta-google ttosta-google changed the title Reset or Shutdown the ConnectorRegistry Add reset to the ConnectorRegistry Nov 14, 2023
@ttosta-google ttosta-google mentioned this issue Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ttosta-google ttosta-google

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add reset to ConnectorRegistry GoogleCloudPlatform/alloydb-java-connector
1 participant
@ttosta-google