Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PersistentVolume with external storage support for in-cluster databases #1068

Open
mathieu-benoit opened this issue Nov 3, 2022 · 3 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@mathieu-benoit
Copy link
Contributor

Today, the in-cluster accounts-db and ledger-db databases are StatefulSets, using an emptyDir volume. As a best practice for such in-cluster scenario it would be great to have the PersistentVolume with an external storage. Maybe with Filestore like illustrated here? Or maybe another storage? That will also illustrate yet another great story with multiple Google Cloud services while showing best practices. This will allow Bank of Anthos's users (Googlers, etc.) to have a ready to use solution for such stateful workloads scenarios.

We maybe don't want to have this as default, and we may want to keep this as emptyDir volume by default (?), but maybe to start with a doc or Kustomize overlay would be a great?

Tagging @bourgeoisor @ahrarmonsur @charlieyu1996 as I'm sure they could provide more insights around this and maybe planning this for 2023?

@bourgeoisor
Copy link
Member

We do have an "external to the cluster" database solution: https://github.com/GoogleCloudPlatform/bank-of-anthos/tree/main/extras/cloudsql

But it may be interesting to dig into the idea of "internal database" (maximum amount of customizability and control) coupled with external underlying storage.

@bourgeoisor bourgeoisor added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Nov 3, 2022
@bourgeoisor
Copy link
Member

This idea is definitely on the back-burner now, but it could still be an interesting alternative.

@bourgeoisor bourgeoisor changed the title accounts-db and ledger-db with PersistentVolume with external storage PersistentVolume with external storage support for in-cluster databases May 3, 2023
@NimJay
Copy link
Collaborator

NimJay commented Oct 24, 2023

Commenting since this is near out-of-SLO:

  • Net-new samples is not a team priority today. Keeping this issue at p3.
  • We should keep this open because it's a great idea!
  • Something similar was also requested in Add database persistent storage #189.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants