Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go] Modules sharing packages example #518

Merged
merged 5 commits into from Jul 10, 2019
Merged

[Go] Modules sharing packages example #518

merged 5 commits into from Jul 10, 2019

Conversation

DazWilkin
Copy link
Contributor

@imjasonh -- added an example.

@googlebot googlebot added the cla: yes CLA looks good label Jul 10, 2019
go.mod Outdated
@@ -0,0 +1,5 @@
module github.com/DazWilkin/cloud-builders
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file necessary? It should be enough to have the go.mod in go/examples/multi_step/ right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm... user error.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies. Fixed: ecb516f

Copy link
Contributor

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@imjasonh imjasonh merged commit cf071bc into GoogleCloudPlatform:master Jul 10, 2019
jakebiesinger-onduo pushed a commit to jakebiesinger/cloud-builders that referenced this pull request Nov 3, 2019
* Attempt to clarify Modules and Mirror

* Reflect @imjasonh feedback

* Added "multi_step" example

* Undo stoopid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA looks good
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants