Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: unbound variable error when running sandboxctl #1045

Closed
1 task done
lvaylet opened this issue Sep 5, 2023 · 0 comments · Fixed by #1060
Closed
1 task done

[Bug]: unbound variable error when running sandboxctl #1045

lvaylet opened this issue Sep 5, 2023 · 0 comments · Fixed by #1060
Assignees
@minherz
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Milestone
version 0.10

Comments

@lvaylet
Copy link

lvaylet commented Sep 5, 2023

Version of Cloud Ops Sandbox

0.9.2

Your client machine OS?

Linux

Tell us, what is a problem?

With a fresh git clone installation, sandboxctl outputs an unbound variable error on every call. No big deal but users might wonder if something is wrong.

Example:

XXXXXXXX@cloudshell:~/cloud-ops-sandbox/provisioning$ ./sandboxctl
./sandboxctl: line 214: VERSION: unbound variable
sandboxctl 
usage: sandboxctl [SUBCOMMAND] [OPTION]...

Create or destroy Cloud Ops Sandbox in a Google Cloud environment. Options
specified over flags 

SUBCOMMANDS:
  create                              Create will attempt to launch a new Cloud
                                      Ops Sandbox
[...]

What you expected to happen?

I expected the current version of sandboxctl to be displayed instead of the unbound variable error.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@lvaylet lvaylet added triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Sep 5, 2023
@lvaylet lvaylet mentioned this issue Sep 5, 2023
Closed
4 tasks
@arbrown arbrown added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed triage me I really want to be triaged. labels Sep 7, 2023
@minherz minherz mentioned this issue Sep 17, 2023
Merged
@minherz minherz added this to the version 0.10 milestone Oct 24, 2023
@minherz minherz mentioned this issue Oct 24, 2023
Merged
minherz added a commit that referenced this issue Oct 24, 2023
@minherz
feat: convert Terraform configuration from plain files to modules (#1054
78b8e1d 
)

Replace 'loging' with 'login' in tutorial and README instructions and adds "create" command in markdown. (#1047)
Fixes errors (#1045) and refactors use of kustomize path in CLI.
Makes GKE+ASM provisioning a module.
Makes Online Boutique provisioning a module.
Creates a new 'main.tf' TF configuration to provision modules sequentially, because of the hard dependency there is no effective way to paralelize it.
Refactors "online-boutique" to replace with "microservices-demo".
@minherz minherz mentioned this issue Oct 27, 2023
Closed
@minherz minherz mentioned this issue Nov 6, 2023
Closed
1 task
minherz added a commit that referenced this issue Nov 21, 2023
@minherz
fix: error for version cmd and refactor code
15e527b 
use SANDBOX_VERSION var to fix behavior of --version param. fixes #1045.
refactor to remove unused vars, store config path in one place.
@minherz minherz mentioned this issue Nov 21, 2023
Merged
minherz added a commit that referenced this issue Nov 25, 2023
@minherz
feat: convert Terraform configuration from plain files to modules (#1054
bb68acb 
)

Replace 'loging' with 'login' in tutorial and README instructions and adds "create" command in markdown. (#1047)
Fixes errors (#1045) and refactors use of kustomize path in CLI.
Makes GKE+ASM provisioning a module.
Makes Online Boutique provisioning a module.
Creates a new 'main.tf' TF configuration to provision modules sequentially, because of the hard dependency there is no effective way to paralelize it.
Refactors "online-boutique" to replace with "microservices-demo".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@minherz minherz

Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
version 0.10
3 participants
@arbrown @minherz @lvaylet