This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
chore: update website version number #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
|
minherz
reviewed
Oct 19, 2021
| @@ -74,6 +74,7 @@ jobs: | |||
| sed -i -e "s/cloudshell_git_branch=v\([0-9\.]\+\)/cloudshell_git_branch=${NEW_VERSION}/g" ${REPO_ROOT}/website/deploy/index.html; | |||
| sed -i -e "s/productVersion': 'v\([0-9\.]\+\)/productVersion': '${NEW_VERSION}/g" ${REPO_ROOT}/website/deploy/index.html; | |||
| sed -i -e "s/uncertified:v\([0-9\.]\+\)/uncertified:${NEW_VERSION}/g" ${REPO_ROOT}/website/deploy/index.html; | |||
| sed -i -e "s/version = \"v\([0-9\.]\+\)\"/version = \"${NEW_VERSION}\"/g" ${REPO_ROOT}/website/config.toml; | |||
There was a problem hiding this comment.
nit: without testing sed command aren't there two many double-quotes?
There was a problem hiding this comment.
It seems alright to me. I count 2 pairs of two inside, and one outer pair. And the command seems to work
| @@ -96,7 +96,7 @@ archived_version = false | |||
| # The version number for the version of the docs represented in this doc set. | |||
| # Used in the "version-banner" partial to display a version number for the | |||
| # current doc set. | |||
| version = "1.0" | |||
| version = "v0.7.0" | |||
There was a problem hiding this comment.
do we downgrade version?!
There was a problem hiding this comment.
We want the docs version to match the actual release version. Previously it was just hard-coded to 1.0
simonz130
approved these changes
Oct 19, 2021
Closed
Merged
This was referenced Jul 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the website had a hard-coded version number of "1.0". This PR updates it to the current (v0.7.0), and adds a line to the
make-releaseGitHub Action so that this value will be updated on each releaseFixes: #663