Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use buildpacks when Dockerfile is not present #44

Merged
merged 1 commit into from
Jul 16, 2019
Merged

use buildpacks when Dockerfile is not present #44

merged 1 commit into from
Jul 16, 2019

Conversation

poy
Copy link
Contributor

@poy poy commented Jun 18, 2019

This CL uses the heroku/buildpacks builder if a Dockerfile is not found.

fixes #43

@jamesward
Copy link
Contributor

This is great! Think we should have any tests around this?

@ahmetb
Copy link
Contributor

ahmetb commented Jun 18, 2019

Thanks for this!
Mostly lgtm, mainly my concern in #43 and some cosmetics.

Dockerfile Outdated Show resolved Hide resolved
@ahmetb
Copy link
Contributor

ahmetb commented Jun 19, 2019

this is lgtm
hold until we figure out how we can ship pack CLI in the shell image.

@jamesward
Copy link
Contributor

jamesward commented Jun 19, 2019

Going through some legal review stuff, can we move pack to /opt/pack/pack and symlink it into /usr/local/bin and also include the license in the /opt/pack dir?

@poy
Copy link
Contributor Author

poy commented Jun 19, 2019

@jamesward

Going through some legal review stuff, can we move pack to /opt/pack/pack and symlink it into /usr/local/bin and also include the license in the /opt/pack dir?

done

@poy
Copy link
Contributor Author

poy commented Jun 19, 2019

This is great! Think we should have any tests around this?

Discussed with @jamesward offline, we decided to punt on tests for the moment until the project is pretty structured for them.

@jamesward
Copy link
Contributor

@jamesward

Going through some legal review stuff, can we move pack to /opt/pack/pack and symlink it into /usr/local/bin and also include the license in the /opt/pack dir?

done

I updated my comment after you saw it. :) Can you sub-dir it and put the pack license in that subdir?

@poy
Copy link
Contributor Author

poy commented Jun 19, 2019

I updated my comment after you saw it. :) Can you sub-dir it and put the pack license in that subdir?

@jamesward Seems more likely that I didn't read it very carefully :)

Updated. PTAL

cmd/cloudshell_open/main.go Outdated Show resolved Hide resolved
This CL uses the heroku/buildpacks builder if a Dockerfile is not found.

fixes #43
@jamesward jamesward merged commit f22c193 into GoogleCloudPlatform:master Jul 16, 2019
@jamesward
Copy link
Contributor

This is now working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add buildpack support
3 participants