-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use buildpacks when Dockerfile is not present #44
Conversation
This is great! Think we should have any tests around this? |
Thanks for this! |
this is lgtm |
Going through some legal review stuff, can we move |
done |
Discussed with @jamesward offline, we decided to punt on tests for the moment until the project is pretty structured for them. |
I updated my comment after you saw it. :) Can you sub-dir it and put the pack license in that subdir? |
@jamesward Seems more likely that I didn't read it very carefully :) Updated. PTAL |
This CL uses the heroku/buildpacks builder if a Dockerfile is not found. fixes #43
This hasn't rolled out yet, but when it does, this should work: |
This is now working! |
This CL uses the heroku/buildpacks builder if a Dockerfile is not found.
fixes #43