Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prefer io.asyncer:r2dbc-mysql #1264

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

mscheong01
Copy link
Contributor

@mscheong01 mscheong01 commented Apr 18, 2023

The R2DBC driver, r2dbc-mysql, has transitioned to new maintainership as detailed in this GitHub issue. The new fork has been updated to accommodate recent r2dbc-spi changes, making it compatible with the General Availability (GA) version 1.0.0.

Given that this fork was officially endorsed by the original owner, it is a reliable alternative to switch to io.asyncer:r2dbc-mysql. We kindly request that this change be expedited and released, as it is currently impeding our migration from Spring Boot 2 to Spring Boot 3.

@mscheong01 mscheong01 requested a review from a team as a code owner April 18, 2023 04:59
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Apr 18, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@enocom
Copy link
Member

enocom commented Apr 18, 2023

Thanks for the PR @mscheong01. I need to take some time to look at this, as we sync this code into Google's internal monorepo and sometimes have to deal with dependency issues.

@enocom enocom added the tests: run Label to trigger Github Action tests. label Apr 18, 2023
@github-actions github-actions bot removed the tests: run Label to trigger Github Action tests. label Apr 18, 2023
@enocom enocom added the tests: run Label to trigger Github Action tests. label Apr 24, 2023
@github-actions github-actions bot removed the tests: run Label to trigger Github Action tests. label Apr 24, 2023
@enocom enocom changed the title use io.asyncer:r2dbc-mysql instead of dev.miku:r2dbc-mysql for r2dbc compatibility feat: prefer io.asyncer:r2dbc-mysql Apr 24, 2023
@enocom enocom changed the title feat: prefer io.asyncer:r2dbc-mysql feat: prefer io.asyncer:r2dbc-mysql Apr 24, 2023
@enocom enocom merged commit 974c199 into GoogleCloudPlatform:main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants