Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support jasync-r2dbc-mysql driver #1263

Open
davin111 opened this issue Apr 18, 2023 · 4 comments
Open

Support jasync-r2dbc-mysql driver #1263

davin111 opened this issue Apr 18, 2023 · 4 comments
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@davin111
Copy link

davin111 commented Apr 18, 2023

Feature Description

Currently for r2dbc mysql, the dev.miku should be used. However, because the repository have not been maintained for quite long time and the driver is not compatible with the version 1 of r2dbc.spi (and so spring boot 3), Spring Boot removed it from its release and r2dbc.io also acknowledged it. Users of r2dbc mysql have moved to jasync-r2dbc-mysql or r2dbc-mariadb, etc. I saw the issue #990, but I think supporting jasync-r2dbc-mysql is also valuable. Could you consider it?

Sample code

No response

Alternatives Considered

No response

Additional Details

No response

@davin111 davin111 added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Apr 18, 2023
@enocom enocom added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Apr 18, 2023
@enocom
Copy link
Member

enocom commented Apr 25, 2023

@davin111 Does #1264 address any of the concerns here?

@enocom
Copy link
Member

enocom commented Apr 25, 2023

We can treat this issue as a feature request for jasync-r2dbc-mysql.

#1264 unblocked Spring Boot 3 support meanwhile.

@mscheong01
Copy link
Contributor

mscheong01 commented Apr 26, 2023

Based on my understanding, in order to use jasync-r2dbc-mysql or any other r2dbc driver, this library would need to acquire the ConnectionFactoryProvider through java spi rather than directly using that of a specific driver. However, since this library seems to rely on r2dbc-mysql's ssl tunneling functionalities, which are not supported by r2dbc-spi, it seems impossible to implement at the moment.

One potential solution could be to support certain drivers by checking for their existence one-by-one, as demonstrated in this example.
However, this would only allow us to support drivers with ssl tunneling functionality.

Please note that I may be mistaken about certain aspects, so please feel free to correct me if necessary.

@enocom
Copy link
Member

enocom commented Apr 26, 2023

If Spring Boot 3 is the driving concern, I think we've fixed that with #1264.

Are there other reasons to support jasync-r2dbc-mysql (or postgres)?

@ttosta-google ttosta-google self-assigned this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

5 participants