refactor!: rename type to ipType #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackwotherspoon
requested changes
Apr 12, 2023
There was a problem hiding this comment.
@shubha-rajan We will want to update the README sample usage to show ipType as well right?
You are absolutely right. Just updated the README. |
ruyadorno
suggested changes
Apr 12, 2023
There was a problem hiding this comment.
Let's land this one as a breaking change (in order to make sure it gets properly noted in the changelog, maybe use refactor!: ?) and then we can adjust the version to v0.3.0 manually prior to the next release (in order to keep the magic zero logic for public preview).
shubha-rajan
changed the title
jackwotherspoon
approved these changes
Apr 12, 2023
ruyadorno
reviewed
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.