Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialization actions for RAPIDS libraries #529

Merged
merged 19 commits into from
Jun 7, 2019
Merged

Initialization actions for RAPIDS libraries #529

merged 19 commits into from
Jun 7, 2019

Conversation

randerzander
Copy link
Contributor

Creating initialization actions for RAPIDS, a suite of GPU accelerated analytics and data science libraries.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@randerzander
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

Copy link
Contributor

@aniket486 aniket486 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @randerzander. Please consider adding an integration test, if possible :) (For example - https://github.com/GoogleCloudPlatform/dataproc-initialization-actions/pull/391/files)
Otherwise, I'll get around to testing/merging this change next week.

rapids/README.md Outdated Show resolved Hide resolved
rapids/install-gpu-driver.sh Outdated Show resolved Hide resolved
rapids/README.md Outdated Show resolved Hide resolved
rapids/README.md Show resolved Hide resolved
rapids/README.md Outdated Show resolved Hide resolved
rapids/README.md Outdated Show resolved Hide resolved
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@randerzander
Copy link
Contributor Author

I signed it!

@randerzander
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Copy link
Contributor

@aniket486 aniket486 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution, @randerzander!

rapids/rapids.sh Show resolved Hide resolved
rapids/test_rapids.py Outdated Show resolved Hide resolved
rapids/internal/install-gpu-driver.sh Outdated Show resolved Hide resolved
rapids/internal/launch-dask.sh Show resolved Hide resolved
rapids/internal/launch-dask.sh Show resolved Hide resolved
rapids/internal/launch-dask.sh Outdated Show resolved Hide resolved
rapids/internal/launch-dask.sh Outdated Show resolved Hide resolved
rapids/README.md Outdated Show resolved Hide resolved
randerzander and others added 2 commits June 5, 2019 00:12
Adding zone parameter also requires it be added to upload_test_file, remove_test_script methods.
Workaround is to set default zone to desirable one before running the test.
@aniket486 aniket486 added cla: yes and removed cla: no labels Jun 7, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@aniket486 aniket486 merged commit a45ad58 into GoogleCloudDataproc:master Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants