Skip to content
This repository has been archived by the owner on Jul 25, 2024. It is now read-only.

refactor(issue-367): clean up flask ui for public preview #371

Merged
merged 7 commits into from
May 9, 2022
Merged

refactor(issue-367): clean up flask ui for public preview #371

merged 7 commits into from
May 9, 2022

Conversation

pattishin
Copy link
Collaborator

Issue: #367

Cleaning up flask frontend for public preview.

Resolves the following views:

  • create donation form

before
Screen Shot 2022-05-05 at 6 47 50 PM

after
Screen Shot 2022-05-05 at 8 22 02 PM

  • create campaign form

before
Screen Shot 2022-05-05 at 6 47 41 PM

after
Screen Shot 2022-05-05 at 8 21 46 PM

  • view campaign page

before
Screen Shot 2022-05-05 at 6 48 03 PM

after
Screen Shot 2022-05-05 at 8 21 33 PM

  • home page view

before
Screen Shot 2022-05-05 at 6 47 29 PM

after
Screen Shot 2022-05-05 at 8 21 27 PM

  • access denied error page

before
Screen Shot 2022-05-05 at 8 18 48 PM

after
Screen Shot 2022-05-05 at 8 16 31 PM

@pattishin pattishin requested a review from a team as a code owner May 6, 2022 03:26
@pattishin pattishin linked an issue May 6, 2022 that may be closed by this pull request
refactor(flask-frontend): (Story) Evaluate current UI for flask app (public preview) #367
Closed
@ace-n ace-n self-requested a review May 6, 2022 18:24
ace-n
ace-n reviewed May 6, 2022
View reviewed changes
website/static/site.css
color: #505050;
font-family: Roboto, sans-serif;
font-display: swap;
font-family: 'Google Sans', sans-serif !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to avoid !important here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ideal for now, but would like to still apply it for now. Added this in order to make sure the donations table picked this up. I wanted to avoid adding too many css lines to make sure the font was being applied.

Copy link
Contributor

@ace-n ace-n May 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we leave a TODO comment linking to a GitHub issue to remove the important?

(If and when we deprecate the Flask frontend, we can close that issue + remove the TODO.)

website/templates/base.html Show resolved Hide resolved
website/templates/errors/401.html Show resolved Hide resolved
website/templates/errors/base.html

.mdc-top-app-bar,
.mdc-button {
background: #306DFD !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto - can we avoid !important here?

Copy link
Collaborator Author

@pattishin pattishin May 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

̶T̶h̶i̶s̶ ̶c̶a̶n̶ ̶g̶e̶t̶ ̶r̶e̶m̶o̶v̶e̶d̶ ̶👍🏼
Update: Double-checked. Will need to leave this in for now. The default color for the bar and button is the original purple without adding !important.

Screen Shot 2022-05-06 at 4 31 31 PM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above - keeping !important sounds fine, provided we include a link (via code comments) to a GitHub issue tracking its (eventual) removal.

website/templates/home.html Show resolved Hide resolved
website/templates/view-campaign.html Show resolved Hide resolved
@pattishin
Copy link
Collaborator Author

pattishin commented May 6, 2022 •
edited
Loading

@ace-n All updated! Ready for re-review

ace-n
ace-n approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@ace-n ace-n left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM provided we document removing !important as a TODO.

website/static/site.css
color: #505050;
font-family: Roboto, sans-serif;
font-display: swap;
font-family: 'Google Sans', sans-serif !important;
Copy link
Contributor

@ace-n ace-n May 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we leave a TODO comment linking to a GitHub issue to remove the important?

(If and when we deprecate the Flask frontend, we can close that issue + remove the TODO.)

website/templates/errors/base.html

.mdc-top-app-bar,
.mdc-button {
background: #306DFD !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above - keeping !important sounds fine, provided we include a link (via code comments) to a GitHub issue tracking its (eventual) removal.

@pattishin pattishin merged commit 3dcc178 into main May 9, 2022
@pattishin pattishin deleted the refactor/issue-367 branch May 9, 2022 20:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ace-n ace-n ace-n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor(flask-frontend): (Story) Evaluate current UI for flask app (public preview)
2 participants
@pattishin @ace-n