This repository has been archived by the owner on Jul 25, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 61
refactor(issue-367): clean up flask ui for public preview #371
Merged
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2dd413f
refactor: fixing form inputs, home & campaign styling
pattishin 0552738
refactor: small styling for view campaign page
pattishin 850048d
refactor: fixing broken styling on flask error pages
pattishin 0b6e548
Merge branch 'main' into refactor/issue-367
pattishin 3e9eb39
Merge branch 'main' into refactor/issue-367
pattishin 47c053a
refactor: applying pr suggestions
pattishin 3e9b16a
chore: adding comment ref to issue
pattishin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,8 +14,55 @@ | |
limitations under the License. | ||
--> | ||
|
||
<style> | ||
body { | ||
margin: 0; | ||
font-family: 'Google Sans', sans-serif; | ||
} | ||
|
||
.emblem-message { | ||
width: 100%; | ||
background-color: #efefef; | ||
color: #606060; | ||
display: block; | ||
padding: 0.75em; | ||
text-align: center; | ||
} | ||
|
||
.mdc-top-app-bar, | ||
.mdc-button { | ||
background: #306DFD !important; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ditto - can we avoid There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As above - keeping |
||
} | ||
|
||
.material-icons { | ||
font-size: 14px; | ||
} | ||
|
||
.error-root { | ||
padding: 0.75em; | ||
font-size: 20px; | ||
} | ||
|
||
.error-message, .error-caption { | ||
text-align: center; | ||
} | ||
|
||
.error-root .error-message { | ||
display: block; | ||
font-weight: bold; | ||
text-align: center; | ||
} | ||
|
||
.error-caption { | ||
display: block; | ||
font-style: italic; | ||
padding-top: 0.5em; | ||
text-align: center; | ||
} | ||
</style> | ||
{% extends "base.html" %} | ||
|
||
|
||
{% block content %} | ||
<div class="error-root"> | ||
<p> | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to avoid
!important
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not ideal for now, but would like to still apply it for now. Added this in order to make sure the donations table picked this up. I wanted to avoid adding too many css lines to make sure the font was being applied.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we leave a
TODO
comment linking to a GitHub issue to remove theimportant
?(If and when we deprecate the Flask frontend, we can close that issue + remove the TODO.)