Version 1.3.1

[elharo]

@chanseokoh

[chanseokoh]

I think the release instructions are not up to date. I remember @briandealwis and I decided that we retain .qualifier here and drop it temporarily when actually building binaries in a local tag branch (which is indeed not ideal). I'll update the release instructions.

[chanseokoh]

We should retain .qualifier in this PR. I have updated the release instructions accordingly:

5. Checkout the tag: git checkout <tag>.
6. Use git status to verify there are no local changes. Make sure you see "nothing to commit, working directory clean".
7. Drop the .qualifier in gcp-repo/metadata.product (e.g., version="1.3.0.qualifier" to version="1.3.0") and use the exact release version (#2211). Do not commit. git status should show that gcp-repo/metadata.product is the only file that changed.

@briandealwis we are good with this, aren't we?

[briandealwis]

That's what we did before. Perhaps we should change it slightly and:

• increment 1.3.1.qualifier
• commit & push to master
• tag 1.3.1
• drop the .qualifier and do the actual build

Otherwise master stays at 1.3.0.qualifier and we'll need to fix that up separately.

[chanseokoh]

That's exactly what I am saying. This PR will change the version to 1.3.1.qualifier.

[codecov]

Codecov Report

Merging #2363 into master will increase coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master   #2363      +/-   ##
===========================================
+ Coverage     71.43%   71.5%   +0.06%     
- Complexity     2122    2125       +3     
===========================================
  Files           325     325              
  Lines         12909   12909              
  Branches       1273    1273              
===========================================
+ Hits           9222    9230       +8     
+ Misses         3157    3151       -6     
+ Partials        530     528       -2

Impacted Files	Coverage Δ	Complexity Δ
...tools/eclipse/test/util/ThreadDumpingWatchdog.java	65.58% <0%> (+0.93%)	39% <0%> (+1%)	⬆️
...ow/ui/preferences/RunOptionsDefaultsComponent.java	76.01% <0%> (+1.35%)	32% <0%> (+1%)	⬆️
...le/cloud/tools/eclipse/util/status/StatusUtil.java	95% <0%> (+7.5%)	20% <0%> (+1%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b57c3a...39509a0. Read the comment docs.

[elharo]

PTAL

[briandealwis]

LGTM

[briandealwis]

The rationale for dropping the .qualifier from the product was: since this is a marketing version, this version only ever appears in the category metadata that's shown in the Install Wizard, and we will never re-release a version (we won't re-release 1.3.1, we'll just do 1.3.2), it made sense to have the product version reflect the marketing version. We leave the .qualifier for our normal builds in case we ever aggregate builds (e.g., nightlies).