Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category version in install binary has ".qualifier" #2211

Closed
chanseokoh opened this issue Aug 1, 2017 · 2 comments
Closed

Category version in install binary has ".qualifier" #2211

chanseokoh opened this issue Aug 1, 2017 · 2 comments
Assignees

Comments

@chanseokoh
Copy link
Contributor

We always had the .qualifier part in our code, so this seems to be a post-effect of #2043.

selection_031

selection_032

@briandealwis
Copy link
Member

briandealwis commented Aug 1, 2017

Ah it's because of our post-signing product re-publishing step:

  1. Run the Eclipse p2 Product Publisher to add our custom p2 metadata to the repository.

which manually invokes the p2 product publisher and thus doesn't benefit from the .qualifier expansion performed by Tycho.

Given that this is a release version, and the category IU is never actually downloaded to the user (and thus doesn't need to be unique), we should just update the release instructions to drop the .qualifier when updating the .product version.

This issue can go away whenever we're able to do signing as part of the build process.

@briandealwis
Copy link
Member

Updated release doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants