pubsub: enable streaming pull #2212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Moving this to a branch. If nothing else, we should perf test this before declaring it release-ready. This commit re-enables streaming pull. Unlike previous implementation, it does not fall back to polling if streaming is unavailable, since the streaming pull endpoint should be working by the time this is released. This commit fixes a bug deadline modification code. Previously we record an Instant we receive a message, then call Instant::getNano to get the time in nanoseconds. This is incorrect since getNano returns the nanosecond from the beginning of that second, not since an epoch. The fix is to simply save the time since epoch instead of Instant. This commit also slightly changes how errors are logged, so that errors that occur after the service is being shut down don't spam the console.
pongad
changed the title
| } | ||
|
|
||
| @Override | ||
| protected void doStop() { | ||
| // stopAllStreamingConnections(); | ||
| stopAllStreamingConnections(); | ||
| stopAllPollingConnections(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
|
||
| ackDeadlineUpdater = | ||
| executor.scheduleAtFixedRate( | ||
| new Runnable() { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Sorry I accidentally merged this. I've reset the branch and re-posted this at #2223 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving this to a branch.
If nothing else, we should perf test this before
declaring it release-ready.
This commit re-enables streaming pull.
Unlike previous implementation,
it does not fall back to polling if streaming is unavailable,
since the streaming pull endpoint should be working
by the time this is released.
This commit fixes a bug deadline modification code.
Previously we record an Instant we receive a message,
then call Instant::getNano to get the time in nanoseconds.
This is incorrect since getNano returns the nanosecond
from the beginning of that second, not since an epoch.
The fix is to simply save the time since epoch instead of Instant.
This commit also slightly changes how errors are logged,
so that errors that occur after the service is being shut down
don't spam the console.