Add windows password test #985
Conversation
|
Skipping CI for Draft Pull Request. |
imagetest/utils/test_utils.go
Outdated
| } | ||
| fqdnString = strings.TrimSpace(procStatus.Stdout) | ||
| } else { | ||
| fqdnBytes, err := exec.Command("curl", "http://metadata.google.internal/computeMetadata/v1/instance/hostname", "-H", "Metadata-Flavor: Google").Output() |
There was a problem hiding this comment.
This mechanism seems kind of fragile, since it relies on DNS naming conventions. It will break if project level DNS is not set to zonal or if the instance edits DNS settings or uses a custom hostname, which is something we do in some tests. We also have instance/zone, project/project-id, and instance/name keys to tell use these things authoritatively.
| } | ||
|
|
||
| projectNumber, instanceZone, err := getProjectAndZone() |
There was a problem hiding this comment.
I don't think there's any remaining callers of this function after deleting this, just delete the function too
|
/hold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-crate, koln67 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Tests windows automated password generation, similar to the example: https://cloud.google.com/compute/docs/instances/windows/automate-pw-generation
In this test, it first creates the user, then runs the example code, and finally validates that the new password for the user is correct.