Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add precondition blocking use of c3 machine with pd-standard #1579

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

nick-stroud
Copy link
Collaborator

@nick-stroud nick-stroud commented Jul 12, 2023

To help prevent confusion such as #1568.

Tested manually. Error is raised before any infrastructure is deployed.

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

@nick-stroud nick-stroud changed the title Add pre-condition blocking use of c3 machine with pd-standard in Slurm Add precondition blocking use of c3 machine with pd-standard Jul 12, 2023
@nick-stroud nick-stroud assigned mr0re1 and unassigned cboneti Jul 14, 2023
@nick-stroud nick-stroud requested a review from mr0re1 July 14, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants