Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Slurm-GCP v5 examples and references as legacy #2567

Merged

Conversation

harshthakkar01
Copy link
Contributor

@harshthakkar01 harshthakkar01 commented May 10, 2024

Note to reviewer.
This PR updates all slurm-gcp v5 examples to legacy. For easy review please refer individual commit.
Also, this will be followed by harshthakkar01#1 once this is checked in.

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

@harshthakkar01 harshthakkar01 added the release-deprecations Added to release notes under the "Deprecations" heading. label May 10, 2024
@harshthakkar01
Copy link
Contributor Author

/gcbrun

@harshthakkar01
Copy link
Contributor Author

/gcbrun

examples/README.md Outdated Show resolved Hide resolved
tools/cloud-build/daily-tests/builds/packer-v5-legacy.yaml Outdated Show resolved Hide resolved
community/examples/hpc-slurm-ubuntu2004-v5-legacy.yaml Outdated Show resolved Hide resolved
@harshthakkar01 harshthakkar01 merged commit 33e2487 into GoogleCloudPlatform:develop May 13, 2024
8 of 47 checks passed
@harshthakkar01 harshthakkar01 mentioned this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-deprecations Added to release notes under the "Deprecations" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants