-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove semistandard
#712
Labels
good first issue
This issue is a good place to started contributing to this repository.
priority: p3
Desirable enhancement or fix. May not be included in next release.
type: cleanup
An internal cleanup or hygiene concern.
Comments
I think we should still do this. Commenting to reset SLO. |
smeet07
added a commit
to smeet07/microservices-demo
that referenced
this issue
Sep 14, 2022
I looked into payments service and currency service and I don't think it is being used in a meaningful way
bourgeoisor
added a commit
that referenced
this issue
Sep 16, 2022
* adressing issue #712 Remove semistandard I looked into payments service and currency service and I don't think it is being used in a meaningful way * removing semistandard as dev dependency * removing lint script * removing lint script from payment service removing lint script from payments service since we have already removed semistandard module so it wouldn't work anyways * forgot to remove ","s in payments services * frogot to remove ","s in currency service json Co-authored-by: Olivier Bourgeois <3271352+bourgeoisor@users.noreply.github.com>
D-Mwanth
pushed a commit
to D-Mwanth/microservices-demo
that referenced
this issue
Mar 6, 2024
…tform#1051) * adressing issue GoogleCloudPlatform#712 Remove semistandard I looked into payments service and currency service and I don't think it is being used in a meaningful way * removing semistandard as dev dependency * removing lint script * removing lint script from payment service removing lint script from payments service since we have already removed semistandard module so it wouldn't work anyways * forgot to remove ","s in payments services * frogot to remove ","s in currency service json Co-authored-by: Olivier Bourgeois <3271352+bourgeoisor@users.noreply.github.com>
This was referenced Mar 22, 2024
This was referenced Mar 22, 2024
This was referenced Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
good first issue
This issue is a good place to started contributing to this repository.
priority: p3
Desirable enhancement or fix. May not be included in next release.
type: cleanup
An internal cleanup or hygiene concern.
Describe request or inquiry
devDependecy
.microservices-demo/src/currencyservice/package.json
Line 24 in d893682
microservices-demo/src/paymentservice/package.json
Line 24 in d893682
What purpose/environment will this feature serve?
Additional Info
The text was updated successfully, but these errors were encountered: