Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove semistandard #712

Closed
2 tasks
NimJay opened this issue Feb 8, 2022 · 1 comment
Closed
2 tasks

Remove semistandard #712

NimJay opened this issue Feb 8, 2022 · 1 comment
Labels
good first issue This issue is a good place to started contributing to this repository. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@NimJay
Copy link
Collaborator

NimJay commented Feb 8, 2022 •
edited
Loading

Describe request or inquiry

What purpose/environment will this feature serve?

  • This is a clean-up task.
  • This will help reduce the bloat of this app.

Additional Info
@NimJay NimJay added type: cleanup An internal cleanup or hygiene concern. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Feb 8, 2022
@bourgeoisor
Copy link
Member

I think we should still do this. Commenting to reset SLO.

@NimJay NimJay added the good first issue This issue is a good place to started contributing to this repository. label Sep 12, 2022
smeet07 added a commit to smeet07/microservices-demo that referenced this issue Sep 14, 2022
@smeet07
adressing issue GoogleCloudPlatform#712 Remove semistandard
4eaaa68 
I looked into payments service and currency service and I don't think it is being used in a meaningful way
@smeet07 smeet07 mentioned this issue Sep 14, 2022
Merged
bourgeoisor added a commit that referenced this issue Sep 16, 2022
@smeet07 @bourgeoisor
adressing Remove semistandard #712 (#1051)
c70bcf2 
* adressing issue #712 Remove semistandard

I looked into payments service and currency service and I don't think it is being used in a meaningful way

* removing semistandard as dev dependency

* removing lint script

* removing lint script from payment service

removing lint script from payments service since we have already removed semistandard module so it wouldn't work anyways

* forgot to remove ","s in payments services

* frogot to remove ","s in currency service json

Co-authored-by: Olivier Bourgeois <3271352+bourgeoisor@users.noreply.github.com>
@tsmithv11 tsmithv11 mentioned this issue Jul 21, 2023
Open
@haseebH haseebH mentioned this issue Nov 27, 2023
Open
@DSOTraining DSOTraining mentioned this issue Nov 27, 2023
Open
@davidb-github davidb-github mentioned this issue Nov 27, 2023
Open
@DSOTraining DSOTraining mentioned this issue Nov 27, 2023
Open
@davidb-github davidb-github mentioned this issue Nov 30, 2023
Open
@haseebH haseebH mentioned this issue Dec 19, 2023
Open
This was referenced Dec 19, 2023
Open
Open
@haseebH haseebH mentioned this issue Dec 20, 2023
Open
@davidb-github davidb-github mentioned this issue Dec 20, 2023
Open
D-Mwanth pushed a commit to D-Mwanth/microservices-demo that referenced this issue Mar 6, 2024
@smeet07 @bourgeoisor
adressing Remove semistandard GoogleCloudPlatform#712 (GoogleCloudPla…
ad53f4f 
…tform#1051)

* adressing issue GoogleCloudPlatform#712 Remove semistandard

I looked into payments service and currency service and I don't think it is being used in a meaningful way

* removing semistandard as dev dependency

* removing lint script

* removing lint script from payment service

removing lint script from payments service since we have already removed semistandard module so it wouldn't work anyways

* forgot to remove ","s in payments services

* frogot to remove ","s in currency service json

Co-authored-by: Olivier Bourgeois <3271352+bourgeoisor@users.noreply.github.com>
@davidb-github davidb-github mentioned this issue Mar 22, 2024
Open
This was referenced Mar 22, 2024
Open
Open
This was referenced Mar 22, 2024
Open
Open
This was referenced Mar 22, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue This issue is a good place to started contributing to this repository. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bourgeoisor @NimJay