adressing Remove semistandard #712 #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I looked into payments service and currency service and I don't think it is being used in a meaningful way
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
yes I think we could remove that as well |
|
since we are removing semistandard module, the script wont work anyways |
removing lint script from payments service since we have already removed semistandard module so it wouldn't work anyways
smeet07
requested review from
bourgeoisor and
mathieu-benoit
and removed request for
bourgeoisor
smeet07
requested review from
bourgeoisor and
mathieu-benoit
and removed request for
mathieu-benoit and
bourgeoisor
smeet07
requested review from
bourgeoisor
and removed request for
mathieu-benoit
|
Thanks for your contribution @smeet07, much appreciated! |
|
No problem, Always happy to help |
D-Mwanth
pushed a commit
to D-Mwanth/microservices-demo
that referenced
this pull request
Mar 6, 2024
…tform#1051) * adressing issue GoogleCloudPlatform#712 Remove semistandard I looked into payments service and currency service and I don't think it is being used in a meaningful way * removing semistandard as dev dependency * removing lint script * removing lint script from payment service removing lint script from payments service since we have already removed semistandard module so it wouldn't work anyways * forgot to remove ","s in payments services * frogot to remove ","s in currency service json Co-authored-by: Olivier Bourgeois <3271352+bourgeoisor@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
I don't think semistandard is being used in a meaningful way therefore removed it as a devdependency
Fixes
Remove semistandard #712
Change Summary
Additional Notes
Testing Procedure
Related PRs or Issues