Skip to content

Commit

Permalink
adressing Remove semistandard #712 (#1051)
Browse files Browse the repository at this point in the history
* adressing issue #712 Remove semistandard

I looked into payments service and currency service and I don't think it is being used in a meaningful way

* removing semistandard as dev dependency

* removing lint script

* removing lint script from payment service

removing lint script from payments service since we have already removed semistandard module so it wouldn't work anyways

* forgot to remove ","s in payments services

* frogot to remove ","s in currency service json

Co-authored-by: Olivier Bourgeois <3271352+bourgeoisor@users.noreply.github.com>
  • Loading branch information
smeet07 and bourgeoisor authored Sep 16, 2022
1 parent 223cb70 commit c70bcf2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 10 deletions.
6 changes: 1 addition & 5 deletions src/currencyservice/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@
"description": "A gRPC currency conversion microservice",
"repository": "https://github.com/GoogleCloudPlatform/microservices-demo",
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1",
"lint": "semistandard *.js"
"test": "echo \"Error: no test specified\" && exit 1"
},
"license": "Apache-2.0",
"dependencies": {
Expand All @@ -19,8 +18,5 @@
"pino": "8.5.0",
"request": "2.88.2",
"xml2js": "0.4.23"
},
"devDependencies": {
"semistandard": "16.0.1"
}
}
6 changes: 1 addition & 5 deletions src/paymentservice/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@
"repository": "https://github.com/GoogleCloudPlatform/microservices-demo",
"main": "index.js",
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1",
"lint": "semistandard *.js"
"test": "echo \"Error: no test specified\" && exit 1"
},
"author": "Jonathan Lui",
"license": "ISC",
Expand All @@ -19,8 +18,5 @@
"pino": "8.5.0",
"simple-card-validator": "^1.1.0",
"uuid": "^3.2.1"
},
"devDependencies": {
"semistandard": "16.0.1"
}
}

0 comments on commit c70bcf2

Please sign in to comment.