chore: add CODEOWNERS file to repo #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
punya
approved these changes
Feb 22, 2023
leonardopliski
pushed a commit
to leonardopliski/opentelemetry-operations-js
that referenced
this pull request
Mar 15, 2023
aabmass
added a commit
that referenced
this pull request
Mar 17, 2023
…efore creating them (#533) * fix: ensure we try to retrieve the metric descriptors before creating them * test: ensure we try to retrieve the metric descriptors before creating them * fix: detect OTel host.name property from instance/name instead of hostname (#529) * chore: add CODEOWNERS file to repo (#530) * refactor: improve code quality * refactor: improve test spec * refactor: update method name to a better one * refactor: update method description * refactor: update snapshot tests * test: ensure mountProjectIdPath() works as expected * refactor: reuse parameter in method * refactor: fix eslint errors * refactor: update method name * refactor: add code improvements * test: update test spec return status code * refactor: add underscore help identifying it's a private method for JS clients Co-authored-by: Aaron Abbott <aaronabbott@google.com> * refactor: update test string to a hardcoded value to improve readability Co-authored-by: Aaron Abbott <aaronabbott@google.com> * refactor: update method name * refactor: reuse mountProjectId() util * refactor: change string to single quote * chore: update copyright to 2023 --------- Co-authored-by: Aaron Abbott <aaronabbott@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should auto-assign the review group when a PR is opened.