-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure cloud monitoring exporter checks for metric descriptors before creating them #533
fix: ensure cloud monitoring exporter checks for metric descriptors before creating them #533
Conversation
9d30a51
to
e0c6c3e
Compare
packages/opentelemetry-cloud-monitoring-exporter/test/instrument-snapshot.test.ts
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #533 +/- ##
==========================================
+ Coverage 95.99% 96.05% +0.06%
==========================================
Files 18 18
Lines 649 659 +10
Branches 118 119 +1
==========================================
+ Hits 623 633 +10
Misses 26 26
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
778295f
to
6dac146
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments otherwise LGTM :)
packages/opentelemetry-cloud-monitoring-exporter/src/monitoring.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-cloud-monitoring-exporter/test/monitoring.test.ts
Outdated
Show resolved
Hide resolved
…S clients Co-authored-by: Aaron Abbott <aaronabbott@google.com>
Co-authored-by: Aaron Abbott <aaronabbott@google.com>
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
@leonardopliski could you address the header-check and conventional commits CI (the PR title should follow conventional commits) |
Sure, on it @aabmass |
Done @aabmass, should be good go to now |
/gcbrun |
Changes:
cloud-monitoring-exporter
tries to create time series metric descriptors on every application bootstrap #528.