Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure cloud monitoring exporter checks for metric descriptors before creating them #533

Merged

Conversation

leonardopliski
Copy link
Contributor

@leonardopliski leonardopliski commented Mar 11, 2023

Changes:

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #533 (d4b458c) into main (d5f34a3) will increase coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head d4b458c differs from pull request most recent head bf03520. Consider uploading reports for the commit bf03520 to get more accurate results

@@            Coverage Diff             @@
##             main     #533      +/-   ##
==========================================
+ Coverage   95.99%   96.05%   +0.06%     
==========================================
  Files          18       18              
  Lines         649      659      +10     
  Branches      118      119       +1     
==========================================
+ Hits          623      633      +10     
  Misses         26       26              
Impacted Files Coverage Δ
...emetry-cloud-monitoring-exporter/src/monitoring.ts 95.65% <100.00%> (+0.41%) ⬆️
...entelemetry-cloud-monitoring-exporter/src/utils.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@leonardopliski leonardopliski force-pushed the fix/metric-descriptors-retrieval branch from 778295f to 6dac146 Compare March 15, 2023 20:07
Copy link
Contributor

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments otherwise LGTM :)

@aabmass
Copy link
Contributor

aabmass commented Mar 17, 2023

/gcbrun

Copy link
Contributor

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@aabmass
Copy link
Contributor

aabmass commented Mar 17, 2023

@leonardopliski could you address the header-check and conventional commits CI (the PR title should follow conventional commits)

@leonardopliski
Copy link
Contributor Author

header

Sure, on it @aabmass

@leonardopliski leonardopliski changed the title [BUG-FIX] Metric descriptors retrieval fix: ensure cloud monitoring exporter checks for metric descriptors before creating them Mar 17, 2023
@leonardopliski
Copy link
Contributor Author

@leonardopliski could you address the header-check and conventional commits CI (the PR title should follow conventional commits)

Done @aabmass, should be good go to now

@aabmass
Copy link
Contributor

aabmass commented Mar 17, 2023

/gcbrun

@aabmass aabmass enabled auto-merge (squash) March 17, 2023 16:00
@aabmass aabmass merged commit 94687f5 into GoogleCloudPlatform:main Mar 17, 2023
@leonardopliski leonardopliski deleted the fix/metric-descriptors-retrieval branch March 17, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloud-monitoring-exporter tries to create time series metric descriptors on every application bootstrap
2 participants