Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to v1 cloud asset inventory. #252

Merged
merged 3 commits into from
May 16, 2019
Merged

Move to v1 cloud asset inventory. #252

merged 3 commits into from
May 16, 2019

Conversation

bmenasha
Copy link
Contributor

Also only map CAI to API properties for compute resources.

Also only map CAI to API properties for compute resources.
@googlebot googlebot added the cla: yes All committers have signed a CLA label May 15, 2019
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label May 15, 2019
Copy link

@jaketf jaketf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jaketf jaketf merged commit 1547947 into GoogleCloudPlatform:master May 16, 2019
monobinab pushed a commit to monobinab/professional-services that referenced this pull request Sep 18, 2019
* Move to v1 cloud asset inventory.
Also only map CAI to API properties for compute resources.

* need later version of google-cloud-asset for v1 api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes All committers have signed a CLA size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants