-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: bump com.google.cloud:libraries-bom from 26.22.0 to 26.23.0 #2183
deps: bump com.google.cloud:libraries-bom from 26.22.0 to 26.23.0 #2183
Conversation
Bumps [com.google.cloud:libraries-bom](https://github.com/googleapis/java-cloud-bom) from 26.22.0 to 26.23.0. - [Release notes](https://github.com/googleapis/java-cloud-bom/releases) - [Changelog](https://github.com/googleapis/java-cloud-bom/blob/main/release-please-config.json) - [Commits](googleapis/java-cloud-bom@v26.22.0...v26.23.0) --- updated-dependencies: - dependency-name: com.google.cloud:libraries-bom dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Running autoconfig generation https://github.com/GoogleCloudPlatform/spring-cloud-gcp/actions/runs/6237902294 |
I believe this is caused by the library list being faulty. The generated list contains:
2 separate lines, which explains why @mpeddada1 found the log with cc: @suztomo |
@@ -66,7 +66,8 @@ for d in ./google-cloud-java/*java-*/; do | |||
monorepo_name=$(echo $d | sed 's#^./google-cloud-java/##' | sed 's#/$##') | |||
|
|||
# get folder location source of truth from ".OwlBot.yaml" | |||
googleapis_path=$(grep 'java/gapic-google' $d/.OwlBot.yaml | sed 's#^.*"/##' | sed 's#/[^/]*/.\*-java.*$##') | |||
# will only consider the first occurence | |||
googleapis_path=$(grep -e 'java/gapic-google' $d/.OwlBot.yaml | head -n 1| sed 's#^.*"/##' | sed 's#/[^/]*/.\*-java.*$##') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @diegomarquezp! |
Looks like this code generation update is replacing some v1 classes with v2 which is causing the following error:
@meltsufin @diegomarquezp for the client libraries, |
googleapis/google-cloud-java@c713970 introduced Do we want to generate for every version instead? edit: I oversaw that @mpeddada1 already pointed this out :) |
Removing syntax test subcase as it is not found in v2 |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
continuation of #2166
It previously produced a broken row in
library_list.txt
due to agrep
that produced more than one result when inspecting a monorepo library's.OwlBot.yaml
.I'm assuming we only want the first occurrence since the broken row comes from
policytroubleshooting
that also has a certain.../iam/v3
that doesn't look involved with the "main" library