Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump com.google.cloud:libraries-bom from 26.22.0 to 26.23.0 #2183

Merged

Conversation

diegomarquezp
Copy link
Contributor

@diegomarquezp diegomarquezp commented Sep 19, 2023

continuation of #2166

It previously produced a broken row in library_list.txt due to a grep that produced more than one result when inspecting a monorepo library's .OwlBot.yaml.
I'm assuming we only want the first occurrence since the broken row comes from policytroubleshooting that also has a certain .../iam/v3 that doesn't look involved with the "main" library

Bumps [com.google.cloud:libraries-bom](https://github.com/googleapis/java-cloud-bom) from 26.22.0 to 26.23.0.
- [Release notes](https://github.com/googleapis/java-cloud-bom/releases)
- [Changelog](https://github.com/googleapis/java-cloud-bom/blob/main/release-please-config.json)
- [Commits](googleapis/java-cloud-bom@v26.22.0...v26.23.0)

---
updated-dependencies:
- dependency-name: com.google.cloud:libraries-bom
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@diegomarquezp
Copy link
Contributor Author

@diegomarquezp
Copy link
Contributor Author

I believe this is caused by the library list being faulty.

The generated list contains:

policytroubleshooter, google/cloud/policytroubleshooter
google/cloud/policytroubleshooter/iam/v1, com.google.cloud:google-cloud-policy-troubleshooter, 1ca7973d74d2d16d610c1d8f252263dc5[423](https://github.com/GoogleCloudPlatform/spring-cloud-gcp/actions/runs/6237902294/job/16932539623#step:10:424)bbfd, java-policy-troubleshooter

2 separate lines, which explains why @mpeddada1 found the log with artifact_id=1ca7973d74d2d16d610c1d8f252263dc5423bbfd and so on in her comment

cc: @suztomo

@@ -66,7 +66,8 @@ for d in ./google-cloud-java/*java-*/; do
monorepo_name=$(echo $d | sed 's#^./google-cloud-java/##' | sed 's#/$##')

# get folder location source of truth from ".OwlBot.yaml"
googleapis_path=$(grep 'java/gapic-google' $d/.OwlBot.yaml | sed 's#^.*"/##' | sed 's#/[^/]*/.\*-java.*$##')
# will only consider the first occurence
googleapis_path=$(grep -e 'java/gapic-google' $d/.OwlBot.yaml | head -n 1| sed 's#^.*"/##' | sed 's#/[^/]*/.\*-java.*$##')
Copy link
Contributor Author

@diegomarquezp diegomarquezp Sep 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only have one case where we get two or more matches.
If instead of selecting the first occurrence we filter with something like v(.*).*java/gapic-google we may fix the issue for policytroubleshooting but we have other older yamls that don't have this pattern (example)

@mpeddada1
Copy link
Contributor

Thanks @diegomarquezp!

@mpeddada1
Copy link
Contributor

Looks like this code generation update is replacing some v1 classes with v2 which is causing the following error:

Error:  /home/runner/work/spring-cloud-gcp/spring-cloud-gcp/spring-cloud-previews/google-cloud-language-spring-starter/src/test/java/com/google/cloud/language/v1/spring/LanguageAutoConfigurationTests.java:[65,53] error: cannot find symbol
Error:    symbol:   class LanguageServiceSpringAutoConfiguration
Error:    location: class LanguageAutoConfigurationTests
Error:  -> [Help 1]
Error:  

@meltsufin @diegomarquezp for the client libraries, v1 and v2 packages live side by side instead of the newer one replacing the older one. Is this something we want to emulate in the Spring?

@diegomarquezp
Copy link
Contributor Author

diegomarquezp commented Sep 20, 2023

googleapis/google-cloud-java@c713970 introduced language/v2. This causes the generated autoconfigs to generate v2 instead of v1 since the script only takes the latest non-alpha/beta version. The language tests depend on v1

image

Do we want to generate for every version instead?

edit: I oversaw that @mpeddada1 already pointed this out :)

@diegomarquezp
Copy link
Contributor Author

Removing syntax test subcase as it is not found in v2

@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@mpeddada1 mpeddada1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@diegomarquezp diegomarquezp merged commit 70edcc8 into main Sep 20, 2023
28 of 30 checks passed
@diegomarquezp diegomarquezp deleted the dependabot/maven/com.google.cloud-libraries-bom-26.23.0 branch September 20, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants