Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump com.google.cloud:libraries-bom from 26.30.0 to 26.31.0 #2565

Merged
merged 11 commits into from
Feb 5, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 30, 2024

Bumps com.google.cloud:libraries-bom from 26.30.0 to 26.31.0.

Release notes

Sourced from com.google.cloud:libraries-bom's releases.

v26.31.0

GCP Libraries BOM 26.31.0

Here are the differences from the previous version (26.30.0)

New Addition

  • com.google.cloud:google-cloud-servicehealth:0.1.0
  • com.google.cloud:google-cloud-meet:0.1.0

The group ID of the following artifacts is com.google.cloud.

Notable Changes

google-cloud-bigquery 2.37.0 (prev: 2.36.0)

google-cloud-bigtable 2.32.0 (prev: 2.31.0)

  • Append version to the client name in client-side metrics. (#2062) (9a0cdc8)

google-cloud-spanner 6.57.0 (prev: 6.56.0)

  • Add FLOAT32 enum to TypeCode (#2800) (383fea5)

  • Add support for Proto Columns (#2779) (30d37dd)

  • spanner: Add proto descriptors for proto and enum types in create/update/get database ddl requests (#2774) (4a906bf)

  • Remove google-cloud-spanner-executor from the BOM (#2844) (655000a)

google-cloud-storage 2.32.1 (prev: 2.31.0)

  • Add ability to create a PCU Prefix at the object level (#2345) (d39a4e4)

Other libraries

  • [container] add fields desired_in_transit_encryption_config and in_transit_encryption_config (#10260) (9785f8c)

  • [edgenetwork] add MACsec status for internal links (#10270) (667293a)

  • [infra-manager] added Terraform Plan (#10223) (bd6f6bb)

  • [meet] new module for meet (#10245) (8cdfbe6)

  • [retail] add analytics service (#10261) (458516b)

  • [servicehealth] new module for servicehealth (#10267) (5e565d8)

  • [vertexai] add apiEndpoint (da6eea8)

  • [vertexai] support "publishers/google/models/" prefix (da6eea8)

  • [vertexai] Support Function calling (#10242) (89d2b15)

  • [vmwareengine] Adding ManagementDnsZoneBinding, DnsBindPermission, DnsForwarding, ExternalAccessRule, ExternalAddress, LoggingServer, NetworkPeering, Node and stretched PC features (#10240) (4982e78)

  • [aiplatform] Fix rpc tensorboard_service.proto definitions for BatchCreateTensorboardTimeSeries and BatchReadTensorboardTimeSeriesData (#10221) (90a9033)

  • [batch] remove deprecated field enableOslogin (#10257) (2da4e3e)

  • [cloudtasks] remove BufferTask method which cannot be called from client libraries (#10232) (b5a90c4)

  • [css] remove redundant proto dependency from reports API assembly bazel rule (#10276) (851a09c)

  • use cloud-java-bot username in new library generated PRs and commits (#10266) (0e08104)

... (truncated)

Commits
  • ba97ac2 chore: release main (#6377)
  • 085bb3a deps: update dependency com.google.cloud:google-cloud-spanner-bom to v6.57.0 ...
  • a111325 deps: update dependency com.google.cloud:google-cloud-spanner-jdbc to v2.15.2...
  • 466896d deps: update dependency com.google.cloud:google-cloud-spanner-bom to v6.57.0 ...
  • 965f2b9 deps: update dependency com.google.cloud:google-cloud-pubsublite-bom to v1.12...
  • 88ab161 deps: update dependency com.google.cloud:google-cloud-pubsub-bom to v1.126.2 ...
  • 5c7b9e1 deps: update dependency com.google.cloud:google-cloud-logging-logback to v0.1...
  • c48a76a deps: update dependency com.google.cloud:google-cloud-logging-logback to v0.1...
  • 60d9c13 deps: update dependency com.google.cloud:google-cloud-bigquery to v2.37.0 (#6...
  • 660df5e deps: update dependency com.google.cloud:google-cloud-firestore-bom to v3.16....
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [com.google.cloud:libraries-bom](https://github.com/googleapis/java-cloud-bom) from 26.30.0 to 26.31.0.
- [Release notes](https://github.com/googleapis/java-cloud-bom/releases)
- [Changelog](https://github.com/googleapis/java-cloud-bom/blob/main/release-please-config.json)
- [Commits](googleapis/java-cloud-bom@v26.30.0...v26.31.0)

---
updated-dependencies:
- dependency-name: com.google.cloud:libraries-bom
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner January 30, 2024 04:27
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 30, 2024
@burkedavison
Copy link
Member

burkedavison commented Jan 31, 2024

I'm having some authentication issues at the moment. The change LGTM, but only after I created a test to verify to myself that it would work:

In ConverterAwareMappingSpannerEntityWriterTests.java:

import com.google.iam.v1.AuditLogConfig;
import com.google.iam.v1.Policy;

  @Test
  void writeProtocolMessageEnumTest() {
    Policy abstractMessage = Policy.newBuilder().build();
    AuditLogConfig protocolMessageEnum = AuditLogConfig.newBuilder().build();
    TestEntities.TestEntityProtobuf testEntity = new TestEntities.TestEntityProtobuf(
        "id42",
        abstractMessage,
        protocolMessageEnum);

    WriteBuilder writeBuilder = mock(WriteBuilder.class);
    ValueBinder<WriteBuilder> valueBinder = mock(ValueBinder.class);

    when(writeBuilder.set("id")).thenReturn(valueBinder);
    when(writeBuilder.set("abstractMessage")).thenReturn(valueBinder);
    when(writeBuilder.set("protocolMessageEnum")).thenReturn(valueBinder);

    this.spannerEntityWriter.write(testEntity, writeBuilder::set);

    verify(valueBinder).to(testEntity.id);
    verify(valueBinder).to(abstractMessage);
    verify(valueBinder).to(protocolMessageEnum);
  }

Then in com.google.cloud.spring.data.spanner.core.convert.TestEntities:


  static class TestEntityProtobuf {
    @PrimaryKey String id;

    com.google.iam.v1.Policy abstractMessage;

    com.google.iam.v1.AuditLogConfig protocolMessageEnum;

    TestEntityProtobuf(String id, com.google.iam.v1.Policy abstractMessage, com.google.iam.v1.AuditLogConfig protocolMessageEnum) {
      this.id = id;
      this.abstractMessage = abstractMessage;
      this.protocolMessageEnum = protocolMessageEnum;
    }
  }

Then in the pom.xml for this module:

<dependency>
	<groupId>com.google.api.grpc</groupId>
	<artifactId>proto-google-iam-v1</artifactId>
	<scope>test</scope>
</dependency>

Without your update to the ConverterAwareMappingSpannerEntityWriter, the above test fails.

@lqiu96
Copy link
Contributor

lqiu96 commented Jan 31, 2024

Thank you @burkedavison! I've added that test case in and will re-run the CI. Hopefully the tests should be fixed now.

@lqiu96
Copy link
Contributor

lqiu96 commented Jan 31, 2024

Error:

Error: 9:499 [ERROR] com.google.cloud.spring.data.spanner.repository.it.SpannerRepositoryIntegrationTests.queryMethodsTest_readsAndCounts -- Time elapsed: 1.625 s <<< ERROR!
com.google.cloud.spring.data.spanner.core.mapping.SpannerDataException: The given spannerSupportedType type is not a known Spanner directly-supported column type: interface com.google.protobuf.ProtocolMessageEnum
	at com.google.cloud.spring.data.spanner.core.convert.ConverterAwareMappingSpannerEntityProcessor.canHandlePropertyTypeForSingularRead(ConverterAwareMappingSpannerEntityProcessor.java:135)
	at com.google.cloud.spring.data.spanner.core.convert.ConverterAwareMappingSpannerEntityProcessor.lambda$getCorrespondingSpannerJavaType$1(ConverterAwareMappingSpannerEntityProcessor.java:127)
	at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:178)
	at java.base/java.util.Spliterators$IteratorSpliterator.tryAdvance(Spliterators.java:1856)
	at java.base/java.util.stream.ReferencePipeline.forEachWithCancel(ReferencePipeline.java:129)
	at java.base/java.util.stream.AbstractPipeline.copyIntoWithCancel(AbstractPipeline.java:527)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:513)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
	at java.base/java.util.stream.FindOps$FindOp.evaluateSequential(FindOps.java:150)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base/java.util.stream.ReferencePipeline.findFirst(ReferencePipeline.java:647)
	at 

@lqiu96
Copy link
Contributor

lqiu96 commented Feb 5, 2024

Error:

Caused by: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'hypermediaWebMvcConfigurer': Unsatisfied dependency expressed through method 'hypermediaWebMvcConfigurer' parameter 0: Error creating bean with name 'jacksonObjectMapper': Unsatisfied dependency expressed through method 'jacksonObjectMapper' parameter 0: Error creating bean with name 'jacksonObjectMapperBuilder': Unsatisfied dependency expressed through method 'jacksonObjectMapperBuilder' parameter 1: Error creating bean with name 'pageModule': Instantiation of supplied bean failed

This seems to be a known issue from spring-data-commons: spring-projects/spring-data-commons#3025

Seems like it will be released in v3.2.3

@lqiu96 lqiu96 merged commit 6efd6d0 into main Feb 5, 2024
51 of 52 checks passed
@lqiu96 lqiu96 deleted the dependabot/maven/com.google.cloud-libraries-bom-26.31.0 branch February 5, 2024 16:54
Copy link

sonarcloud bot commented Feb 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants