Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update sanity-checks.sh #2891

Merged
merged 1 commit into from
May 15, 2024
Merged

fix: update sanity-checks.sh #2891

merged 1 commit into from
May 15, 2024

Conversation

alicejli
Copy link
Contributor

@alicejli alicejli commented May 15, 2024

#2890

This updates the columns sanity-checks.sh checks for to match the ones generated by generate-library-list.sh.

Example error: https://github.com/GoogleCloudPlatform/spring-cloud-gcp/actions/runs/9096934589/job/25003567600

accessapproval,  google/cloud/accessapproval/v1,  com.google.cloud:google-cloud-accessapproval,  java/accessapproval, 
sanity check failed:
  the library list entry 'accessapproval' has an empty required cell - see /home/runner/work/spring-cloud-gcp/spring-cloud-gcp/spring-cloud-

df9f705#diff-d70307c629e3ee96cc0a222bda6e4cc1e02a27d95691b81c4c66fa51883ab3a0 removed the googleapis_committish column in spring-cloud-generator/scripts/generate-library-list.sh, but not sanity-checks.sh.

@alicejli alicejli requested a review from a team as a code owner May 15, 2024 14:51
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@alicejli alicejli enabled auto-merge (squash) May 15, 2024 15:03
@alicejli alicejli merged commit 2bd16e5 into main May 15, 2024
10 checks passed
@alicejli alicejli deleted the fixSanityChecks branch May 15, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants