Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simpler local integration tests #2110

Merged

Conversation

hown3d
Copy link
Contributor

@hown3d hown3d commented May 28, 2022

Description

This PR tries to simplify the process of running the integration tests on a developer machine.

  • remove dependency to gsutil and creates a package for interacting with gcs buckets.
  • add pattern matching for dockerfiles
    • in order to run only a portion of dockerfiles during integration testing
    • running all files can exhaust the dockerhub pull limit pretty fast
  • start a local registry during integration-test script execution, if LOCAL environment variable is set.
  • dockerignore to prevent rebuilding kaniko during integration test file changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Simplify local integration tests

Copy link
Collaborator

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution! Anything that makes integration tests easier to run locally will help contributors and reviewers, so thank you so much for this. 🙏

pkg/util/bucket/bucket_util.go Outdated Show resolved Hide resolved
pkg/util/tar_util_test.go Outdated Show resolved Hide resolved
scripts/integration-test.sh Outdated Show resolved Hide resolved
scripts/integration-test.sh Outdated Show resolved Hide resolved
Höhl, Lukas and others added 2 commits June 2, 2022 15:02
Signed-off-by: Höhl, Lukas <lukas.hoehl@accso.de>
Signed-off-by: Lukas Hoehl <ludi.origin@gmail.com>
@imjasonh imjasonh merged commit 679c71c into GoogleContainerTools:main Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants