Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] dev, run, debug use docker cli by default #9103

Closed
ericzzzzzzz opened this issue Sep 29, 2023 · 1 comment · Fixed by #9178
Closed

[bug] dev, run, debug use docker cli by default #9103

ericzzzzzzz opened this issue Sep 29, 2023 · 1 comment · Fixed by #9178
Assignees
Labels
area/build kind/bug Something isn't working

Comments

@ericzzzzzzz
Copy link
Contributor

ericzzzzzzz commented Sep 29, 2023

Some Context

#8430 (comment)
#8430 (comment)

It seemed that we cannot specify platform in docker rest client when cross-platform build was initially implemented, so when platform is set here , skaffold will always use docker cli to build image,

if b.useCLI || (b.useBuildKit != nil && *b.useBuildKit) || len(a.DockerArtifact.CliFlags) > 0 || matcher.IsNotEmpty() {
, the problem is that --check-cluster-node-platforms flag is set to true for dev, run , debug, that makes platform parameter in the above code is alway not empty. We should remove that condition, and inject platform into buildOption when use docker rest client to issue build request to docker host.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build kind/bug Something isn't working
Projects
None yet
1 participant