Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skaffold.yaml: Add global field to hold YAML anchor definitions #9404

Open
dallasvaughan opened this issue Apr 24, 2024 · 0 comments
Open

skaffold.yaml: Add global field to hold YAML anchor definitions #9404

dallasvaughan opened this issue Apr 24, 2024 · 0 comments

Comments

@dallasvaughan
Copy link

Expected behavior

Following the guidance on https://skaffold.dev/docs/references/yaml/ (YAML Anchors section) to define and use YAML anchors for common variable values does not result in JSON schema validation errors for skaffold.yaml.

Actual behavior

Additional global fields added to skaffold.yaml fail validation against the JSON schema because additionalProperties: false

Recommended Schema Change

In order to properly support user-defined anchors without failing schema validation, add a new field definition to the Skaffold JSON schema (like commonVariables or .commonVariables) specifically for defining reused YAML values within skaffold.yaml. Alternatively, add a schema that allows any global field whose name begins with . so that defining custom variables is possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant