Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use register_block_type_from_metadata function #3331

Closed
spacedmonkey opened this issue Jul 21, 2020 · 3 comments · Fixed by #7970
Closed

Use register_block_type_from_metadata function #3331

spacedmonkey opened this issue Jul 21, 2020 · 3 comments · Fixed by #7970
Labels
Group: WordPress Changes related to WordPress or Gutenberg integration Type: Enhancement New feature or improvement of an existing feature

Comments

@spacedmonkey
Copy link
Contributor

Feature Description

The register_block_type_from_metadata function will be added in WordPress 5.5. The web stories plugin should use the register_block_type_from_metadata function and register on attributes in block.json.

Alternatives Considered

Additional Context

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

Implementation Brief
@spacedmonkey spacedmonkey added Type: Enhancement New feature or improvement of an existing feature Group: WordPress Changes related to WordPress or Gutenberg integration Pod: WP & Infra labels Jul 21, 2020
@swissspidy
Copy link
Collaborator

Related: #3330.

@bmattb
Copy link

bmattb commented Aug 5, 2020

recommendation from @spacedmonkey was to wait until 5.5 is released. pretty low priority. after discussion, moving to the icebox. cc @o-fernandez

@dreamofabear dreamofabear added the P3 Nice to have label Sep 22, 2020
@swissspidy swissspidy added P4 and removed P3 Nice to have labels Feb 9, 2021
@spacedmonkey
Copy link
Contributor Author

We could revisit this once #7598 is complete.

@spacedmonkey spacedmonkey mentioned this issue Jun 17, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Group: WordPress Changes related to WordPress or Gutenberg integration Type: Enhancement New feature or improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use register_block_type_from_metadata function GoogleForCreators/web-stories-wp
4 participants
@spacedmonkey @swissspidy @dreamofabear @bmattb