Increase timeout for visual regression test #1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
Type: Bug
swissspidy
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
swissspidy
force-pushed
the
fix/test-timeout
branch
from
c255e0c
to
2131b13
Compare
dvoytenko
suggested changes
May 18, 2020
| @@ -88,6 +88,6 @@ describe('Layer', () => { | |||
| failureThreshold: 0.01, | |||
| failureThresholdType: 'percent', | |||
| }); | |||
| }); | |||
| }, 10000); | |||
There was a problem hiding this comment.
Hmm. That's a lot of timeout. Why would it be this slow?
There was a problem hiding this comment.
The default is 5s (5000ms), this doubles it to 10s (10000ms).
Especially on CI this test might take longer than 5s overall since it starts Puppeteer and needs to take a screenshot and compare it.
dvoytenko
approved these changes
May 18, 2020
obetomuniz
added a commit
that referenced
this pull request
May 18, 2020
* master: (62 commits) Bump puppeteer from 3.0.4 to 3.1.0 (#1826) ignore karma tests from coverage review fixes Update karma.config.js Update .eslintrc Incrase timeout for visual regression test (#1785) Dashboard: Adds Tooltips. Borders around Preview Cards. (#1800) Update issue & PR templates (#1824) Add docs about Stories Labs env (#1815) Bump @wordpress/e2e-test-utils from 4.6.0 to 4.7.0 (#1790) Add a basic database upgrader. (#1751) Fix Design Panel scrolling on Safari (#1724) Add useCallback for DropTargetsProvider and MediaPane (#1709) Use useMemo for context values (#1707) Bump eslint-plugin-jest from 23.13.0 to 23.13.1 (#1819) Move jobs with dependencies together Alignment text element while editing (#1717) Workflow: Do build in release assets job Ignore patches folder from build Fix text alignment. (#1802) ...
obetomuniz
added a commit
that referenced
this pull request
May 19, 2020
* master: (43 commits) Fix issue templates headers Bump karma from 5.0.5 to 5.0.8 (#1851) add allow-empty-input in linter so that changes in storybook js don't fail in pre-commit (#1850) add FlagsProvider to storybook simplify jasmine eslint rules Bump @testing-library/dom from 7.5.6 to 7.5.7 (#1829) Bump react-moveable from 0.20.6 to 0.20.7 (#1827) Bump puppeteer from 3.0.4 to 3.1.0 (#1826) review fixes Karma: puppeeter support and native events ignore karma tests from coverage review fixes Update karma.config.js Update .eslintrc Incrase timeout for visual regression test (#1785) Dashboard: Adds Tooltips. Borders around Preview Cards. (#1800) Update issue & PR templates (#1824) Add docs about Stories Labs env (#1815) Bump @wordpress/e2e-test-utils from 4.6.0 to 4.7.0 (#1790) Add a basic database upgrader. (#1751) ...
obetomuniz
added a commit
that referenced
this pull request
May 19, 2020
* master: (77 commits) Fix issue templates headers Bump karma from 5.0.5 to 5.0.8 (#1851) add allow-empty-input in linter so that changes in storybook js don't fail in pre-commit (#1850) add FlagsProvider to storybook simplify jasmine eslint rules Bump @testing-library/dom from 7.5.6 to 7.5.7 (#1829) Bump react-moveable from 0.20.6 to 0.20.7 (#1827) Bump puppeteer from 3.0.4 to 3.1.0 (#1826) review fixes Karma: puppeeter support and native events ignore karma tests from coverage review fixes Update karma.config.js Update .eslintrc Incrase timeout for visual regression test (#1785) Dashboard: Adds Tooltips. Borders around Preview Cards. (#1800) Update issue & PR templates (#1824) Add docs about Stories Labs env (#1815) Bump @wordpress/e2e-test-utils from 4.6.0 to 4.7.0 (#1790) Add a basic database upgrader. (#1751) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increasing the default timeout for this test seems only fair as it does a lot more (i.e. start the browser).