Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add allow-empty-input in linter #1850

Merged
merged 1 commit into from
May 19, 2020
Merged

add allow-empty-input in linter #1850

merged 1 commit into from
May 19, 2020

Conversation

diegovar
Copy link
Contributor

add allow-empty-input in linter so that changes in storybook js don't fail in pre-commit

Prevents this:

husky > pre-commit (node v12.16.2)
✔ Preparing...
⚠ Running tasks...
  ✔ Running tasks for *.js
  ❯ Running tasks for *.(js|css)
    ✖ stylelint --fix [FAILED]
  ↓ No staged files match *.md [SKIPPED]
  ↓ No staged files match *.php [SKIPPED]
  ↓ No staged files match *.(xml|xml.dist) [SKIPPED]
  ↓ No staged files match *.yml [SKIPPED]
↓ Skipped because of errors from tasks. [SKIPPED]
✔ Reverting to original state because of errors...
✔ Cleaning up... 

✖ stylelint --fix:
Error: No files matching the pattern ".storybook/stories/playground/index.js" were found.
    at /Users/diegovar/Development/projects/web-stories-wp/node_modules/stylelint/lib/standalone.js:211:12
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
husky > pre-commit hook failed (add --no-verify to bypass)

@diegovar diegovar requested a review from cvolzke4 May 19, 2020 01:55
@diegovar diegovar removed the request for review from pbakaus May 19, 2020 01:55
@codecov
Copy link

codecov bot commented May 19, 2020

Codecov Report

Merging #1850 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1850   +/-   ##
=========================================
  Coverage     63.86%   63.86%           
  Complexity      235      235           
=========================================
  Files           588      588           
  Lines          9614     9614           
=========================================
  Hits           6140     6140           
  Misses         3474     3474           

@github-actions
Copy link
Contributor

Size Change: 0 B

Total Size: 872 kB

ℹ️ View Unchanged
Filename Size Change
assets/css/edit-story.css 3.04 kB 0 B
assets/css/stories-dashboard.css 3.04 kB 0 B
assets/js/edit-story.js 406 kB 0 B
assets/js/stories-dashboard.js 460 kB 0 B

compressed-size-action

@swissspidy swissspidy merged commit 48d3342 into master May 19, 2020
@swissspidy swissspidy deleted the allow-empty-input-lint branch May 19, 2020 06:07
@swissspidy swissspidy added the Type: Infrastructure Changes impacting testing infrastructure or build tooling label May 19, 2020
obetomuniz added a commit that referenced this pull request May 19, 2020
* master: (43 commits)
  Fix issue templates headers
  Bump karma from 5.0.5 to 5.0.8 (#1851)
  add allow-empty-input in linter so that changes in storybook js don't fail in pre-commit (#1850)
  add FlagsProvider to storybook
  simplify jasmine eslint rules
  Bump @testing-library/dom from 7.5.6 to 7.5.7 (#1829)
  Bump react-moveable from 0.20.6 to 0.20.7 (#1827)
  Bump puppeteer from 3.0.4 to 3.1.0 (#1826)
  review fixes
  Karma: puppeeter support and native events
  ignore karma tests from coverage
  review fixes
  Update karma.config.js
  Update .eslintrc
  Incrase timeout for visual regression test (#1785)
  Dashboard: Adds Tooltips. Borders around Preview Cards. (#1800)
  Update issue & PR templates (#1824)
  Add docs about Stories Labs env (#1815)
  Bump @wordpress/e2e-test-utils from 4.6.0 to 4.7.0 (#1790)
  Add a basic database upgrader. (#1751)
  ...
obetomuniz added a commit that referenced this pull request May 19, 2020
* master:
  Fix issue templates headers
  Bump karma from 5.0.5 to 5.0.8 (#1851)
  add allow-empty-input in linter so that changes in storybook js don't fail in pre-commit (#1850)
  add FlagsProvider to storybook
  simplify jasmine eslint rules
  Bump @testing-library/dom from 7.5.6 to 7.5.7 (#1829)
  Bump react-moveable from 0.20.6 to 0.20.7 (#1827)
  review fixes
  Karma: puppeeter support and native events
  ad flags jsdoc
  add feature flags doc to readme.
  really remove flag
  Remove sample flag and document usage instead.
  add FeatureProvider to arrange test util
  Add basic usage of flags from flagged, integrated into Story_Post_Type.php
obetomuniz added a commit that referenced this pull request May 19, 2020
* master: (77 commits)
  Fix issue templates headers
  Bump karma from 5.0.5 to 5.0.8 (#1851)
  add allow-empty-input in linter so that changes in storybook js don't fail in pre-commit (#1850)
  add FlagsProvider to storybook
  simplify jasmine eslint rules
  Bump @testing-library/dom from 7.5.6 to 7.5.7 (#1829)
  Bump react-moveable from 0.20.6 to 0.20.7 (#1827)
  Bump puppeteer from 3.0.4 to 3.1.0 (#1826)
  review fixes
  Karma: puppeeter support and native events
  ignore karma tests from coverage
  review fixes
  Update karma.config.js
  Update .eslintrc
  Incrase timeout for visual regression test (#1785)
  Dashboard: Adds Tooltips. Borders around Preview Cards. (#1800)
  Update issue & PR templates (#1824)
  Add docs about Stories Labs env (#1815)
  Bump @wordpress/e2e-test-utils from 4.6.0 to 4.7.0 (#1790)
  Add a basic database upgrader. (#1751)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants