Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update issue & PR templates #1824

Merged
merged 1 commit into from
May 18, 2020
Merged

Update issue & PR templates #1824

merged 1 commit into from
May 18, 2020

Conversation

swissspidy
Copy link
Collaborator

No description provided.

@swissspidy swissspidy added Type: Documentation Improvements or additions to documentation Type: Infrastructure Changes impacting testing infrastructure or build tooling labels May 18, 2020
@codecov

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
carloskelly13
carloskelly13 approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@carloskelly13 carloskelly13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. I think getting specifics on where bugs are will be helpful.

BrittanyIRL
BrittanyIRL approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@BrittanyIRL BrittanyIRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the additional context for bugs is a great idea and i like the separation of user facing changes and testing instructions!

@swissspidy swissspidy merged commit 1bad9b2 into master May 18, 2020
@swissspidy swissspidy deleted the chore/update-pr-template branch May 18, 2020 15:39
obetomuniz added a commit that referenced this pull request May 18, 2020
@obetomuniz
Merge branch 'master' into fix/video-bg-overlay
3258317 
* master: (62 commits)
  Bump puppeteer from 3.0.4 to 3.1.0 (#1826)
  ignore karma tests from coverage
  review fixes
  Update karma.config.js
  Update .eslintrc
  Incrase timeout for visual regression test (#1785)
  Dashboard: Adds Tooltips. Borders around Preview Cards. (#1800)
  Update issue & PR templates (#1824)
  Add docs about Stories Labs env (#1815)
  Bump @wordpress/e2e-test-utils from 4.6.0 to 4.7.0 (#1790)
  Add a basic database upgrader. (#1751)
  Fix Design Panel scrolling on Safari (#1724)
  Add useCallback for DropTargetsProvider and MediaPane (#1709)
  Use useMemo for context values (#1707)
  Bump eslint-plugin-jest from 23.13.0 to 23.13.1 (#1819)
  Move jobs with dependencies together
  Alignment text element while editing (#1717)
  Workflow: Do build in release assets job
  Ignore patches folder from build
  Fix text alignment. (#1802)
  ...
obetomuniz added a commit that referenced this pull request May 19, 2020
@obetomuniz
Merge branch 'master' into fix/text-box-not-resizing
f95e480 
* master: (43 commits)
  Fix issue templates headers
  Bump karma from 5.0.5 to 5.0.8 (#1851)
  add allow-empty-input in linter so that changes in storybook js don't fail in pre-commit (#1850)
  add FlagsProvider to storybook
  simplify jasmine eslint rules
  Bump @testing-library/dom from 7.5.6 to 7.5.7 (#1829)
  Bump react-moveable from 0.20.6 to 0.20.7 (#1827)
  Bump puppeteer from 3.0.4 to 3.1.0 (#1826)
  review fixes
  Karma: puppeeter support and native events
  ignore karma tests from coverage
  review fixes
  Update karma.config.js
  Update .eslintrc
  Incrase timeout for visual regression test (#1785)
  Dashboard: Adds Tooltips. Borders around Preview Cards. (#1800)
  Update issue & PR templates (#1824)
  Add docs about Stories Labs env (#1815)
  Bump @wordpress/e2e-test-utils from 4.6.0 to 4.7.0 (#1790)
  Add a basic database upgrader. (#1751)
  ...
obetomuniz added a commit that referenced this pull request May 19, 2020
@obetomuniz
Merge branch 'master' into fix/keydown-on-text-element
18b5657 
* master: (77 commits)
  Fix issue templates headers
  Bump karma from 5.0.5 to 5.0.8 (#1851)
  add allow-empty-input in linter so that changes in storybook js don't fail in pre-commit (#1850)
  add FlagsProvider to storybook
  simplify jasmine eslint rules
  Bump @testing-library/dom from 7.5.6 to 7.5.7 (#1829)
  Bump react-moveable from 0.20.6 to 0.20.7 (#1827)
  Bump puppeteer from 3.0.4 to 3.1.0 (#1826)
  review fixes
  Karma: puppeeter support and native events
  ignore karma tests from coverage
  review fixes
  Update karma.config.js
  Update .eslintrc
  Incrase timeout for visual regression test (#1785)
  Dashboard: Adds Tooltips. Borders around Preview Cards. (#1800)
  Update issue & PR templates (#1824)
  Add docs about Stories Labs env (#1815)
  Bump @wordpress/e2e-test-utils from 4.6.0 to 4.7.0 (#1790)
  Add a basic database upgrader. (#1751)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacedmonkey spacedmonkey spacedmonkey approved these changes

@carloskelly13 carloskelly13 carloskelly13 approved these changes

@BrittanyIRL BrittanyIRL BrittanyIRL approved these changes

@maxyinger maxyinger maxyinger approved these changes

@diegovar diegovar Awaiting requested review from diegovar

@barklund barklund Awaiting requested review from barklund

@jauyong jauyong Awaiting requested review from jauyong

Assignees
No one assigned
Labels
Type: Documentation Improvements or additions to documentation Type: Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@swissspidy @spacedmonkey @carloskelly13 @BrittanyIRL @maxyinger @googlebot