replace pkg_resources with importlib.metadata #213
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
setuptools (pkg_resources) is no longer installed in venvs by default starting in 3.12 as per python/cpython#95299
so code using it doesn't work anymore
Summary of changes made
I replaced the usages of pkg_resources with importlib.metadata
before in meta.py there was some code that removed the jishaku module from it's internal cache; this is no longer needed when using importlib.metadata
another solution to this might be to add setuptools to jishaku's dependencies
Checklist